diff mbox series

dmi: dmicheck: constify array dmi_used_by_kernel_table

Message ID 20170904130041.6286-1-colin.king@canonical.com
State Accepted
Headers show
Series dmi: dmicheck: constify array dmi_used_by_kernel_table | expand

Commit Message

Colin Ian King Sept. 4, 2017, 1 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The array dmi_used_by_kernel_table is static and read-only so also
make it const

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Sept. 5, 2017, 5:30 a.m. UTC | #1 
On 2017-09-04 06:00 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The array dmi_used_by_kernel_table is static and read-only so also
> make it const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/dmi/dmicheck/dmicheck.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 20f28b17..61c6b816 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -264,7 +264,7 @@ static const fwts_dmi_version dmi_versions[] = {
>    *  we care that work,
>    *	see drivers/firmware/dmi_scan.c, dmi_decode()
>    */
> -static fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {
> +static const fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {
>   	/* Type 0 BIOS Information fields */
>   	{ 0, 4 },
>   	{ 0, 5 },
> 
Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Sept. 6, 2017, 8:20 a.m. UTC | #2 
On 09/04/2017 09:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The array dmi_used_by_kernel_table is static and read-only so also
> make it const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/dmi/dmicheck/dmicheck.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 20f28b17..61c6b816 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -264,7 +264,7 @@ static const fwts_dmi_version dmi_versions[] = {
>    *  we care that work,
>    *	see drivers/firmware/dmi_scan.c, dmi_decode()
>    */
> -static fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {
> +static const fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {
>   	/* Type 0 BIOS Information fields */
>   	{ 0, 4 },
>   	{ 0, 5 },
> 


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index 20f28b17..61c6b816 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -264,7 +264,7 @@  static const fwts_dmi_version dmi_versions[] = {
  *  we care that work,
  *	see drivers/firmware/dmi_scan.c, dmi_decode()
  */
-static fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {
+static const fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {
 	/* Type 0 BIOS Information fields */
 	{ 0, 4 },
 	{ 0, 5 },