From patchwork Mon Sep 4 12:20:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 809623 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3xm87Q680xz9t1G; Mon, 4 Sep 2017 22:20:17 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1doqMS-0004s8-7t; Mon, 04 Sep 2017 12:20:16 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1doqMR-0004s2-Ga for fwts-devel@lists.ubuntu.com; Mon, 04 Sep 2017 12:20:15 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1doqMR-0006Ro-1X; Mon, 04 Sep 2017 12:20:15 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: method: constify arrays Date: Mon, 4 Sep 2017 13:20:14 +0100 Message-Id: <20170904122014.18550-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King Constify some read only arrays Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/acpi/method/method.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index d082fc15..71f0a0ee 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -3220,7 +3220,7 @@ static void method_test_CPC_return( { uint8_t revision; - static fwts_package_element elementsv1[] = { + static const fwts_package_element elementsv1[] = { { ACPI_TYPE_INTEGER, "Number of Entries" }, { ACPI_TYPE_INTEGER, "Revision" }, { ACPI_TYPE_INTBUF, "Highest Performance" }, @@ -3240,7 +3240,7 @@ static void method_test_CPC_return( { ACPI_TYPE_BUFFER, "Enable Register" } }; - static fwts_package_element elementsv2[] = { + static const fwts_package_element elementsv2[] = { { ACPI_TYPE_INTEGER, "Number of Entries" }, { ACPI_TYPE_INTEGER, "Revision" }, { ACPI_TYPE_INTBUF, "Highest Performance" }, @@ -3264,7 +3264,7 @@ static void method_test_CPC_return( { ACPI_TYPE_INTBUF, "Reference Performance" } }; - static fwts_package_element elementsv3[] = { + static const fwts_package_element elementsv3[] = { { ACPI_TYPE_INTEGER, "Number of Entries" }, { ACPI_TYPE_INTEGER, "Revision" }, { ACPI_TYPE_INTBUF, "Highest Performance" }, @@ -4402,7 +4402,7 @@ static void method_test_PUR_return( ACPI_OBJECT *obj, void *private) { - static fwts_package_element elements[] = { + static const fwts_package_element elements[] = { { ACPI_TYPE_INTEGER, "RevisionID" }, { ACPI_TYPE_INTEGER, "NumProcessors" }, }; @@ -4641,7 +4641,7 @@ static void method_test_MBM_return( ACPI_OBJECT *obj, void *private) { - static fwts_package_element elements[] = { + static const fwts_package_element elements[] = { { ACPI_TYPE_INTEGER, "Revision" }, { ACPI_TYPE_INTEGER, "Window Size" }, { ACPI_TYPE_INTEGER, "Sampling Interval" }, @@ -4936,7 +4936,7 @@ static void method_test_SBS_return( ACPI_OBJECT *obj, void *private) { - static char *sbs_info[] = { + static const char *sbs_info[] = { "Maximum 1 Smart Battery, system manager/selector not present", "Maximum 1 Smart Battery, system manager/selector present", "Maximum 2 Smart Batteries, system manager/selector present", @@ -5002,7 +5002,7 @@ static void method_test_BIF_return( { bool failed = false; - static fwts_package_element elements[] = { + static const fwts_package_element elements[] = { { ACPI_TYPE_INTEGER, "Power Unit" }, { ACPI_TYPE_INTEGER, "Design Capacity" }, { ACPI_TYPE_INTEGER, "Last Full Charge Capacity" }, @@ -5132,7 +5132,7 @@ static void method_test_BIX_return( { bool failed = false; - static fwts_package_element elements[] = { + static const fwts_package_element elements[] = { { ACPI_TYPE_INTEGER, "Revision" }, { ACPI_TYPE_INTEGER, "Power Unit" }, { ACPI_TYPE_INTEGER, "Design Capacity" }, @@ -5357,7 +5357,7 @@ static int method_test_BST(fwts_framework *fw) static int method_test_BTP(fwts_framework *fw) { - static int values[] = { 0, 1, 100, 200, 0x7fffffff }; + static const int values[] = { 0, 1, 100, 200, 0x7fffffff }; int i; for (i = 0; i < 5; i++) { @@ -5418,7 +5418,7 @@ static int method_test_BTH(fwts_framework *fw) static int method_test_BTM(fwts_framework *fw) { - static int values[] = { 0, 1, 100, 200, 0x7fffffff }; + static const int values[] = { 0, 1, 100, 200, 0x7fffffff }; int i; for (i = 0 ; i < 5; i++) { @@ -5464,7 +5464,7 @@ static int method_test_BMD(fwts_framework *fw) static int method_test_BMC(fwts_framework *fw) { - static int values[] = { 0, 1, 2, 4 }; + static const int values[] = { 0, 1, 2, 4 }; int i; for (i = 0; i < 4; i++) { @@ -5542,7 +5542,7 @@ static void method_test_PIF_return( ACPI_OBJECT *obj, void *private) { - static fwts_package_element elements[] = { + static const fwts_package_element elements[] = { { ACPI_TYPE_INTEGER, "Power Source State" }, { ACPI_TYPE_INTEGER, "Maximum Output Power" }, { ACPI_TYPE_INTEGER, "Maximum Input Power" }, @@ -6627,7 +6627,7 @@ static void method_test_DOD_return( uint32_t i; bool failed = false; - static char *dod_type[] = { + static const char *dod_type[] = { "Other", "VGA, CRT or VESA Compatible Analog Monitor", "TV/HDTV or other Analog-Video Monitor",