diff mbox

acpica/fwts_acpica: remove debug message on FADT/FACS

Message ID 20170523101142.12047-1-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King May 23, 2017, 10:11 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

I accidentally forgot to remove some debug while fixing an earlier
issue.

Fixes: 7ca9ddec47bfad ("acpica: add some extra run time verification to FACP (FADT)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpica/fwts_acpica.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Alex Hung May 23, 2017, 5:57 p.m. UTC | #1
On 2017-05-23 03:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> I accidentally forgot to remove some debug while fixing an earlier
> issue.
> 
> Fixes: 7ca9ddec47bfad ("acpica: add some extra run time verification to FACP (FADT)")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpica/fwts_acpica.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index c26e3e4d..4272c646 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1003,8 +1003,6 @@ static int fwts_acpica_verify_facp_table_pointers(fwts_framework *fw)
>   	if (fadt->dsdt || fadt->x_dsdt) {
>   		if (fwts_acpica_verify_table_get(fw, "DSDT", &table) != FWTS_OK)
>   			return FWTS_ERROR;
> -	printf("FADT DSDT -> %" PRIx32 " %" PRIx64 " %" PRIx64 "\n",
> -		fadt->dsdt, fadt->x_dsdt,  table->addr);
>   		if (((uint64_t)fadt->dsdt != table->addr) &&
>   		    (fadt->x_dsdt != table->addr)) {
>   			fwts_log_error(fw, "FACP points to non-existent DSDT.");
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu May 24, 2017, 2:14 a.m. UTC | #2
On 05/23/2017 06:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> I accidentally forgot to remove some debug while fixing an earlier
> issue.
> 
> Fixes: 7ca9ddec47bfad ("acpica: add some extra run time verification to FACP (FADT)")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpica/fwts_acpica.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index c26e3e4d..4272c646 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1003,8 +1003,6 @@ static int fwts_acpica_verify_facp_table_pointers(fwts_framework *fw)
>   	if (fadt->dsdt || fadt->x_dsdt) {
>   		if (fwts_acpica_verify_table_get(fw, "DSDT", &table) != FWTS_OK)
>   			return FWTS_ERROR;
> -	printf("FADT DSDT -> %" PRIx32 " %" PRIx64 " %" PRIx64 "\n",
> -		fadt->dsdt, fadt->x_dsdt,  table->addr);
>   		if (((uint64_t)fadt->dsdt != table->addr) &&
>   		    (fadt->x_dsdt != table->addr)) {
>   			fwts_log_error(fw, "FACP points to non-existent DSDT.");
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
index c26e3e4d..4272c646 100644
--- a/src/acpica/fwts_acpica.c
+++ b/src/acpica/fwts_acpica.c
@@ -1003,8 +1003,6 @@  static int fwts_acpica_verify_facp_table_pointers(fwts_framework *fw)
 	if (fadt->dsdt || fadt->x_dsdt) {
 		if (fwts_acpica_verify_table_get(fw, "DSDT", &table) != FWTS_OK)
 			return FWTS_ERROR;
-	printf("FADT DSDT -> %" PRIx32 " %" PRIx64 " %" PRIx64 "\n",
-		fadt->dsdt, fadt->x_dsdt,  table->addr);
 		if (((uint64_t)fadt->dsdt != table->addr) &&
 		    (fadt->x_dsdt != table->addr)) {
 			fwts_log_error(fw, "FACP points to non-existent DSDT.");