diff mbox

kernelscan: ensure parse_kernel_message returns PARSER_OK

Message ID 20170413101102.7654-1-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King April 13, 2017, 10:11 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The function was missing a return PARSER_OK.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/utilities/kernelscan.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Hung April 17, 2017, 5:27 p.m. UTC | #1 
On 2017-04-13 03:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function was missing a return PARSER_OK.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/utilities/kernelscan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/utilities/kernelscan.c b/src/utilities/kernelscan.c
> index 759d08cc..c4d0dc57 100644
> --- a/src/utilities/kernelscan.c
> +++ b/src/utilities/kernelscan.c
> @@ -952,6 +952,7 @@ static int parse_kernel_message(parser *p, token *t)
>  		token_clear(t);
>  	}
>  	free(line);
> +	return PARSER_OK;
>  }
>
>  static bool hash_find(char *token)
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu April 21, 2017, 2:41 a.m. UTC | #2 
On 04/13/2017 06:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function was missing a return PARSER_OK.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/utilities/kernelscan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/utilities/kernelscan.c b/src/utilities/kernelscan.c
> index 759d08cc..c4d0dc57 100644
> --- a/src/utilities/kernelscan.c
> +++ b/src/utilities/kernelscan.c
> @@ -952,6 +952,7 @@ static int parse_kernel_message(parser *p, token *t)
>  		token_clear(t);
>  	}
>  	free(line);
> +	return PARSER_OK;
>  }
>
>  static bool hash_find(char *token)
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/utilities/kernelscan.c b/src/utilities/kernelscan.c
index 759d08cc..c4d0dc57 100644
--- a/src/utilities/kernelscan.c
+++ b/src/utilities/kernelscan.c
@@ -952,6 +952,7 @@  static int parse_kernel_message(parser *p, token *t)
 		token_clear(t);
 	}
 	free(line);
+	return PARSER_OK;
 }
 
 static bool hash_find(char *token)