diff mbox

opal: make found_dimm static as it is local to just this source

Message ID 20170315100659.24835-1-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King March 15, 2017, 10:06 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/opal/mem_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung March 15, 2017, 1:17 p.m. UTC | #1 
On 2017-03-15 06:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/opal/mem_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c
> index 2024080..6f88764 100644
> --- a/src/opal/mem_info.c
> +++ b/src/opal/mem_info.c
> @@ -27,7 +27,7 @@
>
>  #include <libfdt.h>
>
> -bool found_dimm = false;
> +static bool found_dimm = false;
>
>  static int get_dimm_property(fwts_framework *fw,
>  			char *my_path,
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu March 16, 2017, 2:22 a.m. UTC | #2 
On 03/15/2017 06:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/opal/mem_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c
> index 2024080..6f88764 100644
> --- a/src/opal/mem_info.c
> +++ b/src/opal/mem_info.c
> @@ -27,7 +27,7 @@
>
>  #include <libfdt.h>
>
> -bool found_dimm = false;
> +static bool found_dimm = false;
>
>  static int get_dimm_property(fwts_framework *fw,
>  			char *my_path,
>


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c
index 2024080..6f88764 100644
--- a/src/opal/mem_info.c
+++ b/src/opal/mem_info.c
@@ -27,7 +27,7 @@ 
 
 #include <libfdt.h>
 
-bool found_dimm = false;
+static bool found_dimm = false;
 
 static int get_dimm_property(fwts_framework *fw,
 			char *my_path,