diff mbox series

efi_runtime: build dkms for kernel that does not have efi_test

Message ID 1528431220-18352-1-git-send-email-alex.hung@canonical.com
State Accepted
Headers show
Series efi_runtime: build dkms for kernel that does not have efi_test | expand

Commit Message

Alex Hung June 8, 2018, 4:13 a.m. UTC
A version of efi_runtime, efi_test, has been sent to upstream since
kernel 4.9, and all supported Ubuntu kernels, except 4.4, haven efi_test
built as a module by default. As a result, the dkms is only required for
kernel 4.4. The also fixes the problem that dkms fails to be installed
on new hardware that has secure boot enabled by default.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 debian/fwts-efi-runtime-dkms.dkms | 1 +
 1 file changed, 1 insertion(+)

Comments

Colin Ian King June 11, 2018, 4:17 p.m. UTC | #1
On 08/06/18 05:13, Alex Hung wrote:
> A version of efi_runtime, efi_test, has been sent to upstream since
> kernel 4.9, and all supported Ubuntu kernels, except 4.4, haven efi_test
> built as a module by default. As a result, the dkms is only required for
> kernel 4.4. The also fixes the problem that dkms fails to be installed
> on new hardware that has secure boot enabled by default.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  debian/fwts-efi-runtime-dkms.dkms | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/fwts-efi-runtime-dkms.dkms b/debian/fwts-efi-runtime-dkms.dkms
> index 94b3415..61c294a 100644
> --- a/debian/fwts-efi-runtime-dkms.dkms
> +++ b/debian/fwts-efi-runtime-dkms.dkms
> @@ -1,6 +1,7 @@
>  PACKAGE_NAME="fwts-efi-runtime-dkms"
>  PACKAGE_VERSION="#MODULE_VERSION#"
>  MAKE[0]="KVER=$kernelver make"
> +BUILD_EXCLUSIVE_KERNEL="^4.4"
>  BUILT_MODULE_NAME[0]="efi_runtime"
>  DEST_MODULE_LOCATION[0]="/updates"
>  AUTOINSTALL="yes"
> 
Good plan, I forgot we should disabled this :-)

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu June 12, 2018, 12:24 p.m. UTC | #2
On 06/08/2018 12:13 PM, Alex Hung wrote:
> A version of efi_runtime, efi_test, has been sent to upstream since
> kernel 4.9, and all supported Ubuntu kernels, except 4.4, haven efi_test
> built as a module by default. As a result, the dkms is only required for
> kernel 4.4. The also fixes the problem that dkms fails to be installed
> on new hardware that has secure boot enabled by default.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   debian/fwts-efi-runtime-dkms.dkms | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/debian/fwts-efi-runtime-dkms.dkms b/debian/fwts-efi-runtime-dkms.dkms
> index 94b3415..61c294a 100644
> --- a/debian/fwts-efi-runtime-dkms.dkms
> +++ b/debian/fwts-efi-runtime-dkms.dkms
> @@ -1,6 +1,7 @@
>   PACKAGE_NAME="fwts-efi-runtime-dkms"
>   PACKAGE_VERSION="#MODULE_VERSION#"
>   MAKE[0]="KVER=$kernelver make"
> +BUILD_EXCLUSIVE_KERNEL="^4.4"
>   BUILT_MODULE_NAME[0]="efi_runtime"
>   DEST_MODULE_LOCATION[0]="/updates"
>   AUTOINSTALL="yes"
> 

Acked-by: Ivan Hu <ivan.hu@canonical.coACK
diff mbox series

Patch

diff --git a/debian/fwts-efi-runtime-dkms.dkms b/debian/fwts-efi-runtime-dkms.dkms
index 94b3415..61c294a 100644
--- a/debian/fwts-efi-runtime-dkms.dkms
+++ b/debian/fwts-efi-runtime-dkms.dkms
@@ -1,6 +1,7 @@ 
 PACKAGE_NAME="fwts-efi-runtime-dkms"
 PACKAGE_VERSION="#MODULE_VERSION#"
 MAKE[0]="KVER=$kernelver make"
+BUILD_EXCLUSIVE_KERNEL="^4.4"
 BUILT_MODULE_NAME[0]="efi_runtime"
 DEST_MODULE_LOCATION[0]="/updates"
 AUTOINSTALL="yes"