diff mbox series

efi_runtime: fix gcc warning for efi_runtime_reset_system

Message ID 1523850160-20178-1-git-send-email-ivan.hu@canonical.com
State Accepted
Headers show
Series efi_runtime: fix gcc warning for efi_runtime_reset_system | expand

Commit Message

Ivan Hu April 16, 2018, 3:42 a.m. UTC
efi_runtime_reset_system function currently not uesed,#if define it out.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 efi_runtime/efi_runtime.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Alex Hung April 16, 2018, 5:07 a.m. UTC | #1
On 2018-04-15 08:42 PM, Ivan Hu wrote:
> efi_runtime_reset_system function currently not uesed,#if define it out.
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   efi_runtime/efi_runtime.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/efi_runtime/efi_runtime.c b/efi_runtime/efi_runtime.c
> index a017a98..d79db78 100644
> --- a/efi_runtime/efi_runtime.c
> +++ b/efi_runtime/efi_runtime.c
> @@ -561,6 +561,10 @@ static long efi_runtime_get_nexthighmonocount(unsigned long arg)
>   	return 0;
>   }
>   
> +#if 0
> +/*
> + *  Note: efi_runtime_reset_system currently not used
> + */
>   static long efi_runtime_reset_system(unsigned long arg)
>   {
>   	struct efi_resetsystem __user *resetsystem_user;
> @@ -584,6 +588,7 @@ static long efi_runtime_reset_system(unsigned long arg)
>   	kfree(data);
>   	return 0;
>   }
> +#endif
>   
>   #if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 1, 0)
>   static long efi_runtime_query_variableinfo(unsigned long arg)
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
Colin Ian King April 16, 2018, 6:56 a.m. UTC | #2
On 16/04/18 04:42, Ivan Hu wrote:
> efi_runtime_reset_system function currently not uesed,#if define it out.
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  efi_runtime/efi_runtime.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/efi_runtime/efi_runtime.c b/efi_runtime/efi_runtime.c
> index a017a98..d79db78 100644
> --- a/efi_runtime/efi_runtime.c
> +++ b/efi_runtime/efi_runtime.c
> @@ -561,6 +561,10 @@ static long efi_runtime_get_nexthighmonocount(unsigned long arg)
>  	return 0;
>  }
>  
> +#if 0
> +/*
> + *  Note: efi_runtime_reset_system currently not used
> + */
>  static long efi_runtime_reset_system(unsigned long arg)
>  {
>  	struct efi_resetsystem __user *resetsystem_user;
> @@ -584,6 +588,7 @@ static long efi_runtime_reset_system(unsigned long arg)
>  	kfree(data);
>  	return 0;
>  }
> +#endif
>  
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 1, 0)
>  static long efi_runtime_query_variableinfo(unsigned long arg)
> 

Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox series

Patch

diff --git a/efi_runtime/efi_runtime.c b/efi_runtime/efi_runtime.c
index a017a98..d79db78 100644
--- a/efi_runtime/efi_runtime.c
+++ b/efi_runtime/efi_runtime.c
@@ -561,6 +561,10 @@  static long efi_runtime_get_nexthighmonocount(unsigned long arg)
 	return 0;
 }
 
+#if 0
+/*
+ *  Note: efi_runtime_reset_system currently not used
+ */
 static long efi_runtime_reset_system(unsigned long arg)
 {
 	struct efi_resetsystem __user *resetsystem_user;
@@ -584,6 +588,7 @@  static long efi_runtime_reset_system(unsigned long arg)
 	kfree(data);
 	return 0;
 }
+#endif
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 1, 0)
 static long efi_runtime_query_variableinfo(unsigned long arg)