From patchwork Fri Sep 8 09:07:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 811393 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3xpWg041jXz9s0g; Fri, 8 Sep 2017 19:07:24 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1dqFFx-0000oI-SQ; Fri, 08 Sep 2017 09:07:21 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1dqFFx-0000oB-0f for fwts-devel@lists.ubuntu.com; Fri, 08 Sep 2017 09:07:21 +0000 Received: from 1.general.alexhung.us.vpn ([10.172.65.254] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1dqFFw-00015L-Gx; Fri, 08 Sep 2017 09:07:20 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/3] lib: fwts_acpi_tables: add a new function to check reserved bits Date: Fri, 8 Sep 2017 02:07:11 -0700 Message-Id: <1504861633-20512-1-git-send-email-alex.hung@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Signed-off-by: Alex Hung Acked-by: Ivan Hu Acked-by: Colin Ian King --- src/lib/include/fwts_acpi_tables.h | 1 + src/lib/src/fwts_acpi_tables.c | 52 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) diff --git a/src/lib/include/fwts_acpi_tables.h b/src/lib/include/fwts_acpi_tables.h index d478d99..011a4c3 100644 --- a/src/lib/include/fwts_acpi_tables.h +++ b/src/lib/include/fwts_acpi_tables.h @@ -54,6 +54,7 @@ bool fwts_acpi_obj_find(fwts_framework *fw, const char *obj_name); fwts_bool fwts_acpi_is_reduced_hardware(const fwts_acpi_table_fadt *fadt); void fwts_acpi_reserved_zero_check(fwts_framework *fw, const char *table, const char *field, uint64_t value, uint8_t size, bool *passed); +void fwts_acpi_reserved_bits_check(fwts_framework *fw, const char *table, const char *field, uint64_t value, uint8_t size, uint8_t min, uint8_t max, bool *passed); #endif diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c index 4ac70f8..15d07f4 100644 --- a/src/lib/src/fwts_acpi_tables.c +++ b/src/lib/src/fwts_acpi_tables.c @@ -1426,4 +1426,56 @@ void fwts_acpi_reserved_zero_check( } } +/* + * fwts_acpi_reserved_bits_check() + * verify whether the reserved bits are zero + */ +void fwts_acpi_reserved_bits_check( + fwts_framework *fw, + const char *table, + const char *field, + uint64_t value, + uint8_t size, + uint8_t min, + uint8_t max, + bool *passed) +{ + uint64_t mask = 0; + uint8_t i; + + for (i = min; i <= max; i++) { + mask |= (1ULL << i); + } + + if (value & mask) { + char label[24]; + strncpy(label, table, 4); /* ACPI table name is 4 char long */ + strncpy(label + 4, "ReservedBitsNonZero", sizeof(label) - 4); + + switch (size) { + case sizeof(uint8_t): + fwts_failed(fw, LOG_LEVEL_HIGH, label, + "%4.4s %s Bits [%" PRIu8 "..%" PRIu8 "] must be zero, got " + "0x%2.2" PRIx8 " instead", table, field, max, min, (uint8_t)value); + break; + case sizeof(uint16_t): + fwts_failed(fw, LOG_LEVEL_HIGH, label, + "%4.4s %s Bits [%" PRIu8 "..%" PRIu8 "] must be zero, got " + "0x%4.4" PRIx16 " instead", table, field, max, min, (uint16_t)value); + break; + case sizeof(uint32_t): + fwts_failed(fw, LOG_LEVEL_HIGH, label, + "%4.4s %s Bits [%" PRIu8 "..%" PRIu8 "] must be zero, got " + "0x%8.8" PRIx32 " instead", table, field, max, min, (uint32_t)value); + break; + case sizeof(uint64_t): + fwts_failed(fw, LOG_LEVEL_HIGH, label, + "%4.4s %s Bits [%" PRIu8 "..%" PRIu8 "] must be zero, got " + "0x%16.16" PRIx64 " instead", table, field, max, min, value); + break; + } + *passed = false; + } +} + #endif