From patchwork Tue Jul 25 06:10:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakar Arora X-Patchwork-Id: 793209 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3xGntj3Shwz9s1h; Tue, 25 Jul 2017 16:11:25 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1dZt40-0005FK-Am; Tue, 25 Jul 2017 06:11:24 +0000 Received: from foss.arm.com ([217.140.101.70]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1dZt3p-0005By-Ig for fwts-devel@lists.ubuntu.com; Tue, 25 Jul 2017 06:11:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0946C2B; Mon, 24 Jul 2017 23:11:13 -0700 (PDT) Received: from u201365.usa.Arm.com (a75592.asiapac.arm.com [10.162.2.158]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E2573F577; Mon, 24 Jul 2017 23:11:10 -0700 (PDT) From: Sakar Arora To: fwts-devel@lists.ubuntu.com Subject: [PATCH 05/10] acpi: gtdt: add SBBR compliance tests Date: Tue, 25 Jul 2017 11:40:52 +0530 Message-Id: <1500963057-4225-6-git-send-email-Sakar.Arora@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500963057-4225-1-git-send-email-Sakar.Arora@arm.com> References: <1500963057-4225-1-git-send-email-Sakar.Arora@arm.com> Cc: Prasanth.Pulla@arm.com, Mahesh.ReddyBireddy@arm.com, Rajat.Goyal@arm.com, Charles.Garcia-Tobin@arm.com X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Rajat Goyal Server Base Boot Requirements (SBBR) specification is intended for SBSA- compliant 64-bit ARMv8 servers. It defines the base firmware requirements for out-of-box support of any ARM SBSA-compatible Operating System or hypervisor. The requirements in this specification are expected to be minimal yet complete for booting a multi-core ARMv8 server platform, while leaving plenty of room for OEM or ODM innovations and design details. For more information, download the SBBR specification here: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044b/index.html This change introduces test cases as per SBBR specification to gtdt acpi table. Signed-off-by: Supreeth Venkatesh Signed-off-by: Rajat Goyal Acked-by: Alex Hung Acked-by: Colin Ian King --- src/acpi/gtdt/gtdt.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/acpi/gtdt/gtdt.c b/src/acpi/gtdt/gtdt.c index da65d60..27d83c8 100644 --- a/src/acpi/gtdt/gtdt.c +++ b/src/acpi/gtdt/gtdt.c @@ -37,8 +37,13 @@ static int gtdt_init(fwts_framework *fw) return FWTS_ERROR; } if (table == NULL || (table && table->length == 0)) { - fwts_log_error(fw, "ACPI GTDT table does not exist, skipping test"); - return FWTS_SKIP; + if (fw->flags & FWTS_FLAG_TEST_SBBR) { + fwts_log_error(fw, "ACPI GTDT table does not exist"); + return FWTS_ERROR; + } else { + fwts_log_error(fw, "ACPI GTDT table does not exist, skipping test"); + return FWTS_SKIP; + } } return FWTS_OK; } @@ -247,6 +252,6 @@ static fwts_framework_ops gtdt_ops = { .minor_tests = gtdt_tests }; -FWTS_REGISTER("gtdt", >dt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI) +FWTS_REGISTER("gtdt", >dt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI | FWTS_FLAG_TEST_SBBR) #endif