From patchwork Tue May 23 19:28:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 766190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3wXQYD6945z9sNV; Wed, 24 May 2017 05:28:16 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1dDFTZ-0006y1-C9; Tue, 23 May 2017 19:28:13 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1dDFTX-0006xn-M7 for fwts-devel@lists.ubuntu.com; Tue, 23 May 2017 19:28:11 +0000 Received: from 1.general.alexhung.us.vpn ([10.172.65.254] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1dDFTW-0006xN-FJ; Tue, 23 May 2017 19:28:10 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] dmi: dmicheck: type 22 offset 9 is an enum from 1 to 8 Date: Tue, 23 May 2017 12:28:07 -0700 Message-Id: <1495567687-6687-1-git-send-email-alex.hung@canonical.com> X-Mailer: git-send-email 2.7.4 Cc: dishit.joshi@intel.com X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- src/dmi/dmicheck/dmicheck.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index 316df7c..5f010f5 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -1591,8 +1591,7 @@ static void dmicheck_entry(fwts_framework *fw, if (data[0x07] || hdr->length < 0x1A) dmi_str_check(fw, table, addr, "Serial Number", hdr, 0x7); dmi_str_check(fw, table, addr, "Device Name", hdr, 0x8); - if (data[0x09] != 0x02 || hdr->length < 0x1A) - dmi_str_check(fw, table, addr, "Device Chemistry", hdr, 0x9); + dmi_min_max_uint8_check(fw, table, addr, "Device Chemistry", hdr, 0x9, 1, 8); dmi_str_check(fw, table, addr, "SBDS Version Number", hdr, 0xe); if (data[0xf] != 0xff)