diff mbox

[2/2] uefi: securebootcert: specify the failure reason for the variable not found

Message ID 1494923449-19709-2-git-send-email-ivan.hu@canonical.com
State Accepted
Headers show

Commit Message

Ivan Hu May 16, 2017, 8:30 a.m. UTC
Comments added, no function changed.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/uefi/securebootcert/securebootcert.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Colin Ian King May 16, 2017, 8:35 a.m. UTC | #1
On 16/05/17 09:30, Ivan Hu wrote:
> Comments added, no function changed.
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/securebootcert/securebootcert.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/uefi/securebootcert/securebootcert.c b/src/uefi/securebootcert/securebootcert.c
> index b836855..b431b4c 100644
> --- a/src/uefi/securebootcert/securebootcert.c
> +++ b/src/uefi/securebootcert/securebootcert.c
> @@ -478,10 +478,10 @@ static int securebootcert_test1(fwts_framework *fw)
>  	if (securebooted || deployed) {
>  		if (!(var_found & VAR_DB_FOUND))
>  			fwts_failed(fw, LOG_LEVEL_HIGH, "SecureBootCertVariableNotFound",
> -				"The secure boot variable DB not found.");
> +				"Secureboot or deployed mode on, but the variable DB not found.");
>  		if (!(var_found & VAR_KEK_FOUND))
>  			fwts_failed(fw, LOG_LEVEL_HIGH, "SecureBootCertVariableNotFound",
> -				"The secure boot variable KEK not found.");
> +				"Secureboot or deployed mode on, but the variable KEK not found.");
>  	} else {
>  		if (!(var_found & VAR_DB_FOUND))
>  			fwts_log_info(fw, "Not in readiness for secureboot, variable DB not found.");		
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Alex Hung May 16, 2017, 6:08 p.m. UTC | #2
On 2017-05-16 01:30 AM, Ivan Hu wrote:
> Comments added, no function changed.
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/securebootcert/securebootcert.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/uefi/securebootcert/securebootcert.c b/src/uefi/securebootcert/securebootcert.c
> index b836855..b431b4c 100644
> --- a/src/uefi/securebootcert/securebootcert.c
> +++ b/src/uefi/securebootcert/securebootcert.c
> @@ -478,10 +478,10 @@ static int securebootcert_test1(fwts_framework *fw)
>  	if (securebooted || deployed) {
>  		if (!(var_found & VAR_DB_FOUND))
>  			fwts_failed(fw, LOG_LEVEL_HIGH, "SecureBootCertVariableNotFound",
> -				"The secure boot variable DB not found.");
> +				"Secureboot or deployed mode on, but the variable DB not found.");
>  		if (!(var_found & VAR_KEK_FOUND))
>  			fwts_failed(fw, LOG_LEVEL_HIGH, "SecureBootCertVariableNotFound",
> -				"The secure boot variable KEK not found.");
> +				"Secureboot or deployed mode on, but the variable KEK not found.");
>  	} else {
>  		if (!(var_found & VAR_DB_FOUND))
>  			fwts_log_info(fw, "Not in readiness for secureboot, variable DB not found.");		
>
Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox

Patch

diff --git a/src/uefi/securebootcert/securebootcert.c b/src/uefi/securebootcert/securebootcert.c
index b836855..b431b4c 100644
--- a/src/uefi/securebootcert/securebootcert.c
+++ b/src/uefi/securebootcert/securebootcert.c
@@ -478,10 +478,10 @@  static int securebootcert_test1(fwts_framework *fw)
 	if (securebooted || deployed) {
 		if (!(var_found & VAR_DB_FOUND))
 			fwts_failed(fw, LOG_LEVEL_HIGH, "SecureBootCertVariableNotFound",
-				"The secure boot variable DB not found.");
+				"Secureboot or deployed mode on, but the variable DB not found.");
 		if (!(var_found & VAR_KEK_FOUND))
 			fwts_failed(fw, LOG_LEVEL_HIGH, "SecureBootCertVariableNotFound",
-				"The secure boot variable KEK not found.");
+				"Secureboot or deployed mode on, but the variable KEK not found.");
 	} else {
 		if (!(var_found & VAR_DB_FOUND))
 			fwts_log_info(fw, "Not in readiness for secureboot, variable DB not found.");