From patchwork Fri Oct 14 19:17:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeffrey Hugo X-Patchwork-Id: 682423 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3swcnc4vmmz9s3T; Sat, 15 Oct 2016 06:18:12 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b=KaEq+6ZCjSnPjBKehXL7rcMdO2B9ujQ5qhMGfxzmjwQGaUUbcY4nzwFM370I+l3XjNZzc4hc8CNpK5TO1ROdawNXney3NbvL6VuI4d7TUUxhX5eXhJeCERsLYMYAQEtOg4ynkQhYHPBs1Ks905yvRD8TMc7muG2zRm/NMmD+X+s=; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b=KaEq+6ZCjSnPjBKehXL7rcMdO2B9ujQ5qhMGfxzmjwQGaUUbcY4nzwFM370I+l3XjNZzc4hc8CNpK5TO1ROdawNXney3NbvL6VuI4d7TUUxhX5eXhJeCERsLYMYAQEtOg4ynkQhYHPBs1Ks905yvRD8TMc7muG2zRm/NMmD+X+s=; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1bv7zf-0005t9-He; Fri, 14 Oct 2016 19:18:11 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1bv7zL-0005kD-Bz for fwts-devel@lists.ubuntu.com; Fri, 14 Oct 2016 19:17:51 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EB016617E5; Fri, 14 Oct 2016 19:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476472669; bh=lbSfWoUN8vkL6bk1+yx30FyU+UGxXqPqGpuNKzvl2LM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KaEq+6ZCjSnPjBKehXL7rcMdO2B9ujQ5qhMGfxzmjwQGaUUbcY4nzwFM370I+l3Xj NZzc4hc8CNpK5TO1ROdawNXney3NbvL6VuI4d7TUUxhX5eXhJeCERsLYMYAQEtOg4y nkQhYHPBs1Ks905yvRD8TMc7muG2zRm/NMmD+X+s= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from jhugo-perf-lnx.qualcomm.com (unknown [129.46.14.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 721F4615B0; Fri, 14 Oct 2016 19:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476472669; bh=lbSfWoUN8vkL6bk1+yx30FyU+UGxXqPqGpuNKzvl2LM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KaEq+6ZCjSnPjBKehXL7rcMdO2B9ujQ5qhMGfxzmjwQGaUUbcY4nzwFM370I+l3Xj NZzc4hc8CNpK5TO1ROdawNXney3NbvL6VuI4d7TUUxhX5eXhJeCERsLYMYAQEtOg4y nkQhYHPBs1Ks905yvRD8TMc7muG2zRm/NMmD+X+s= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 721F4615B0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=jhugo@codeaurora.org From: Jeffrey Hugo To: fwts-devel@lists.ubuntu.com Subject: [PATCH 5/6] acpi: tpm2: Show test as skipped if table does not exist Date: Fri, 14 Oct 2016 13:17:21 -0600 Message-Id: <1476472642-29871-6-git-send-email-jhugo@codeaurora.org> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1476472642-29871-1-git-send-email-jhugo@codeaurora.org> References: <1476472642-29871-1-git-send-email-jhugo@codeaurora.org> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com If the table does not exist, the error message states the test is being skipped, however the test is categorized as aborted. The majority of other tests are categorized as skipped under this scenario. Update the init path to return a SKIP error to categorize the test result similar to other tests. Signed-off-by: Jeffrey Hugo Acked-by: Ivan Hu Acked-by: Colin Ian King --- src/acpi/tpm2/tpm2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/tpm2/tpm2.c b/src/acpi/tpm2/tpm2.c index f4efd83..7c8c4dd 100644 --- a/src/acpi/tpm2/tpm2.c +++ b/src/acpi/tpm2/tpm2.c @@ -33,7 +33,7 @@ static int tpm2_init(fwts_framework *fw) } if (table == NULL) { fwts_log_error(fw, "ACPI TPM2 table does not exist, skipping test"); - return FWTS_ERROR; + return FWTS_SKIP; } return FWTS_OK;