From patchwork Wed Sep 21 22:27:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeffrey Hugo X-Patchwork-Id: 673071 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3sfZ4s1434z9sCp; Thu, 22 Sep 2016 08:27:41 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b=kHnoPabTBBzSNUJx2Qa7DPI+nCgUWnSIiYNkohJowuADhKDQXPfNnSO3qUIR4DRrQzgH/2Z99+P2fUyiVygO0iAcMyKguED2cO8RiYY836r9/dAzil4Pw7UuHPo1jSEaXyQ3Yiq8HEmcwZWyLpZ0REejpdZ3wwGqI51aoSx0gSM=; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b=kHnoPabTBBzSNUJx2Qa7DPI+nCgUWnSIiYNkohJowuADhKDQXPfNnSO3qUIR4DRrQzgH/2Z99+P2fUyiVygO0iAcMyKguED2cO8RiYY836r9/dAzil4Pw7UuHPo1jSEaXyQ3Yiq8HEmcwZWyLpZ0REejpdZ3wwGqI51aoSx0gSM=; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1bmpzN-0005Nr-So; Wed, 21 Sep 2016 22:27:37 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1bmpzI-0005Ng-1q for fwts-devel@lists.ubuntu.com; Wed, 21 Sep 2016 22:27:32 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 47D166156D; Wed, 21 Sep 2016 22:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1474496850; bh=AZQctir7QOV3V3QwpjpnICpFpwLCtdre+n3Fjesk00g=; h=From:To:Cc:Subject:Date:From; b=kHnoPabTBBzSNUJx2Qa7DPI+nCgUWnSIiYNkohJowuADhKDQXPfNnSO3qUIR4DRrQ zgH/2Z99+P2fUyiVygO0iAcMyKguED2cO8RiYY836r9/dAzil4Pw7UuHPo1jSEaXyQ 3Yiq8HEmcwZWyLpZ0REejpdZ3wwGqI51aoSx0gSM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from jhugo-perf-lnx.qualcomm.com (unknown [129.46.14.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C5C8A613FC; Wed, 21 Sep 2016 22:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1474496850; bh=AZQctir7QOV3V3QwpjpnICpFpwLCtdre+n3Fjesk00g=; h=From:To:Cc:Subject:Date:From; b=kHnoPabTBBzSNUJx2Qa7DPI+nCgUWnSIiYNkohJowuADhKDQXPfNnSO3qUIR4DRrQ zgH/2Z99+P2fUyiVygO0iAcMyKguED2cO8RiYY836r9/dAzil4Pw7UuHPo1jSEaXyQ 3Yiq8HEmcwZWyLpZ0REejpdZ3wwGqI51aoSx0gSM= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org C5C8A613FC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=jhugo@codeaurora.org From: Jeffrey Hugo To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: hest: Add new error notification types Date: Wed, 21 Sep 2016 16:27:17 -0600 Message-Id: <1474496837-23149-1-git-send-email-jhugo@codeaurora.org> X-Mailer: git-send-email 1.8.5.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com ACPI 6.1 updated Table 18-345 in Section 18.3.2.9 with additional error notification types. Types 0 - 10 are now defined. Update the test accordingly to prevent false reserved type errors. Signed-off-by: Jeffrey Hugo Acked-by: Colin Ian King Acked-by: Alex Hung --- src/acpi/hest/hest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c index 1d1fa71..eded048 100644 --- a/src/acpi/hest/hest.c +++ b/src/acpi/hest/hest.c @@ -645,13 +645,13 @@ static void hest_check_generic_error_source( "more than zero.", source->max_sections_per_record); } - if (source->notification.type > 7) { + if (source->notification.type > 0xA) { *passed = false; fwts_failed(fw, LOG_LEVEL_HIGH, "HESTInvalidHardwareErrorNotificationType", "HEST Hardware Error Notification Type is " "an invalid reserved value of 0x%2.2" PRIx8 "," - "expecting value 0x00 to 0x07", + "expecting value 0x00 to 0x0A", source->notification.type); } if (source->notification.configuration_write_enable & ~0x3f) { @@ -763,13 +763,13 @@ static void hest_check_generic_error_source_v2( "more than zero.", source->max_sections_per_record); } - if (source->notification.type > 7) { + if (source->notification.type > 0xA) { *passed = false; fwts_failed(fw, LOG_LEVEL_HIGH, "HESTInvalidHardwareErrorNotificationType", "HEST Hardware Error Notification Type is " "an invalid reserved value of 0x%2.2" PRIx8 "," - "expecting value 0x00 to 0x07", + "expecting value 0x00 to 0x0A", source->notification.type); } if (source->notification.configuration_write_enable & ~0x3f) {