From patchwork Tue Jul 12 19:53:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deb McLemore X-Patchwork-Id: 647602 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3rpt2G2TRFz9s8d; Wed, 13 Jul 2016 05:53:58 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1bN3ki-0002cg-Mi; Tue, 12 Jul 2016 19:53:56 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1bN3kb-0002cV-Iw for fwts-devel@lists.ubuntu.com; Tue, 12 Jul 2016 19:53:49 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6CJnBMd015657 for ; Tue, 12 Jul 2016 15:53:48 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2452asjk1b-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 12 Jul 2016 15:53:47 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 Jul 2016 15:53:46 -0400 Received: from d01dlp01.pok.ibm.com (9.56.250.166) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 12 Jul 2016 15:53:45 -0400 X-IBM-Helo: d01dlp01.pok.ibm.com X-IBM-MailFrom: debmc@linux.vnet.ibm.com Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id D79FD38C803B for ; Tue, 12 Jul 2016 15:53:44 -0400 (EDT) Received: from b01ledav03.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6CJrmHN56492138; Tue, 12 Jul 2016 19:53:48 GMT Received: from b01ledav03.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB273B2054; Tue, 12 Jul 2016 15:53:44 -0400 (EDT) Received: from oc6714664003.ibm.com (unknown [9.80.217.128]) by b01ledav03.gho.pok.ibm.com (Postfix) with ESMTP id 6C55FB2046; Tue, 12 Jul 2016 15:53:44 -0400 (EDT) Received: by oc6714664003.ibm.com (Postfix, from userid 1000) id 9302A1C0E45; Tue, 12 Jul 2016 14:53:40 -0500 (CDT) From: Deb McLemore To: fwts-devel@lists.ubuntu.com Subject: [PATCH] opal/prd_info: Improve message when libfdt not installed Date: Tue, 12 Jul 2016 14:53:37 -0500 X-Mailer: git-send-email 1.8.3.1 X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071219-0040-0000-0000-000000CA1E30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071219-0041-0000-0000-000004A44D4F Message-Id: <1468353217-1451-1-git-send-email-debmc@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-07-12_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607120179 Cc: Deb McLemore X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com When running prd_info the device tree validation may not succeed due to functional problems or lack of proper setup and tools. This patch will improve the usability by suggesting methods to diagnose the problem. Signed-off-by: Deb McLemore Acked-by: Colin Ian King Acked-by: Alex Hung --- src/opal/prd_info.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/opal/prd_info.c b/src/opal/prd_info.c index 537d1ed..bdbfb9d 100644 --- a/src/opal/prd_info.c +++ b/src/opal/prd_info.c @@ -200,8 +200,15 @@ static int prd_info_init(fwts_framework *fw) } #endif } else { - fwts_log_info(fw, "The OPAL PRD device tree node" - " is not present so skipping test"); + fwts_log_info(fw, "The OPAL PRD device tree node is not" + " able to be detected so skipping the prd_info" + " test. There may be tools missing such as" + " libfdt-dev or dtc, check that the packages" + " are installed and re-build if needed." + " If this condition persists try running the" + " dt_base test to further diagnose. If dt_base" + " test is not available this is probably a" + " setup problem."); return FWTS_SKIP; }