From patchwork Fri Feb 19 23:39:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Stone X-Patchwork-Id: 585497 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 92CE41402D8; Sat, 20 Feb 2016 10:41:51 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=bwtbPvTN; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1aWugI-0005e4-GI; Fri, 19 Feb 2016 23:41:50 +0000 Received: from mail-ob0-f182.google.com ([209.85.214.182]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.76) (envelope-from ) id 1aWuft-0005V0-0k for fwts-devel@lists.ubuntu.com; Fri, 19 Feb 2016 23:41:25 +0000 Received: by mail-ob0-f182.google.com with SMTP id gc3so121036444obb.3 for ; Fri, 19 Feb 2016 15:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=T4YkVlXfiIIGDtdMFKz/k+poPWmKAwTaARApTnvVbS8=; b=bwtbPvTNmLLUdq3fO/S5FEve1zNHoGaUvhSd75tM4t5hL8/KB0oHCB48o6uVdPh3eK ATItirwv30K76a3P3LcxmcsJ3hobSu4tcBW3KsOdJ//L3k4vg/fo6Z1ICsMwNaLYt9kt xoMzdXuYpRZ0hUqbUGdmgpjj861vV3Jzl86bQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=T4YkVlXfiIIGDtdMFKz/k+poPWmKAwTaARApTnvVbS8=; b=CsKd7loD0g1pGrNPvYGagoojx81UCPLgnX7FoXQQ9MEy4Sjfj1dPOrTPRv2Te/BXA1 6KJQsbEar+R9Rp6EdY71LHnpUp35ksSLXNbFdo/9mA7pt13zgp/m2cRrsUHCc+i8mqM4 jxuj05ZAZWy3+0G8NTsMyG/IqU4z/cc4duBFVv57QFjCu9BXanO651viH5NUkfyJ1+Nl fdNysRVbnzNOVC22AL1Opcs45235KSAFtNBbyz4nw7a4NQmE2CEn8xIfS0/dayjCFME2 d1DMd1ZjH9lsM14G8NKj5Ui7ctlwly/X7dEM1nFxfB7igMsmVRB8xacbtDjbW81obCnT ulpQ== X-Gm-Message-State: AG10YOS/4PGgzxDXmOlmHChdYWF0gPgL0WJbva6I2CNiFs3KKed84VVEB6VhzFUKoFNDuGlC X-Received: by 10.182.48.130 with SMTP id l2mr14751127obn.49.1455925284000; Fri, 19 Feb 2016 15:41:24 -0800 (PST) Received: from fidelio.ahs3.com (c-50-134-239-249.hsd1.co.comcast.net. [50.134.239.249]) by smtp.googlemail.com with ESMTPSA id kg7sm8655217obb.27.2016.02.19.15.41.22 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 15:41:22 -0800 (PST) From: Al Stone To: fwts-devel@lists.ubuntu.com Subject: [PATCH v2 21/23] FADT: remove no longer useful variables from test1 Date: Fri, 19 Feb 2016 16:39:57 -0700 Message-Id: <1455925199-8587-22-git-send-email-al.stone@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1455925199-8587-1-git-send-email-al.stone@linaro.org> References: <1455925199-8587-1-git-send-email-al.stone@linaro.org> Cc: patches@linaro.org, linaro-acpi@lists.linaro.org X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com Now that the tests have been resequenced, added to, and generally overhauled, clean up some variables in test1 that are no longer useful. Signed-off-by: Al Stone Acked-by: Colin Ian King Acked-by: Alex Hung --- src/acpi/fadt/fadt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c index 70b6c8a..40a0028 100644 --- a/src/acpi/fadt/fadt.c +++ b/src/acpi/fadt/fadt.c @@ -1537,8 +1537,6 @@ static void acpi_table_check_fadt_sleep_status_reg(fwts_framework *fw) static int fadt_test1(fwts_framework *fw) { - bool passed = true; - acpi_table_check_fadt_firmware_ctrl(fw); acpi_table_check_fadt_dsdt(fw); acpi_table_check_fadt_reserved(fw); @@ -1612,8 +1610,6 @@ static int fadt_test1(fwts_framework *fw) */ fwts_log_info(fw, "FADT Hypervisor Vendor Identity is %" PRIu64, fadt->hypervisor_id); - if (passed) - fwts_passed(fw, "No issues found in FADT table."); return FWTS_OK; }