diff mbox

fwts-test: only run rsdp regression test on specific arches (LP: #1547602)

Message ID 1455903334-25529-1-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Feb. 19, 2016, 5:35 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

We don't want to run this regression test on architectures such as
armhf and ia64 for the moment.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fwts-test/rsdp-0001/test-0001.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Al Stone Feb. 19, 2016, 7:15 p.m. UTC | #1
On 02/19/2016 10:35 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> We don't want to run this regression test on architectures such as
> armhf and ia64 for the moment.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  fwts-test/rsdp-0001/test-0001.sh | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/fwts-test/rsdp-0001/test-0001.sh b/fwts-test/rsdp-0001/test-0001.sh
> index 4762059..1adaccf 100755
> --- a/fwts-test/rsdp-0001/test-0001.sh
> +++ b/fwts-test/rsdp-0001/test-0001.sh
> @@ -4,6 +4,16 @@ TEST="Test apcitables against broken ACPI RSDP"
>  NAME=test-0001.sh
>  TMPLOG=$TMP/rsdp.log.$$
>  
> +machine=$(uname -m)
> +case $machine in
> +x86 | x86_32 | x86_64 | i686 | arm64 | aarch64)
> +	;;
> +*)
> +        echo SKIP: $TEST, $NAME
> +        exit 77
> +	;;
> +esac
> +
>  $FWTS --log-format="%line %owner " -w 80 --dumpfile=$FWTSTESTDIR/rsdp-0001/acpidump-0001.log rsdp - | cut -c7- | grep "^rsdp" > $TMPLOG
>  diff $TMPLOG $FWTSTESTDIR/rsdp-0001/rsdp.log >> $FAILURE_LOG
>  ret=$?
> 

Out of curiosity, what's the symptom that makes this necessary?  I didn't
see anything in the bug report to clarify.  I could easily have something
amiss in the RSDP tests I added.

Thanks.
Ivan Hu Feb. 24, 2016, 8:43 a.m. UTC | #2
On 2016年02月20日 01:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We don't want to run this regression test on architectures such as
> armhf and ia64 for the moment.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   fwts-test/rsdp-0001/test-0001.sh | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/fwts-test/rsdp-0001/test-0001.sh b/fwts-test/rsdp-0001/test-0001.sh
> index 4762059..1adaccf 100755
> --- a/fwts-test/rsdp-0001/test-0001.sh
> +++ b/fwts-test/rsdp-0001/test-0001.sh
> @@ -4,6 +4,16 @@ TEST="Test apcitables against broken ACPI RSDP"
>   NAME=test-0001.sh
>   TMPLOG=$TMP/rsdp.log.$$
>
> +machine=$(uname -m)
> +case $machine in
> +x86 | x86_32 | x86_64 | i686 | arm64 | aarch64)
> +	;;
> +*)
> +        echo SKIP: $TEST, $NAME
> +        exit 77
> +	;;
> +esac
> +
>   $FWTS --log-format="%line %owner " -w 80 --dumpfile=$FWTSTESTDIR/rsdp-0001/acpidump-0001.log rsdp - | cut -c7- | grep "^rsdp" > $TMPLOG
>   diff $TMPLOG $FWTSTESTDIR/rsdp-0001/rsdp.log >> $FAILURE_LOG
>   ret=$?
>

Thanks!
This patch avoids make check failures on these architectures.

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Alex Hung Feb. 24, 2016, 8:48 a.m. UTC | #3
On 2016-02-20 01:35 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We don't want to run this regression test on architectures such as
> armhf and ia64 for the moment.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   fwts-test/rsdp-0001/test-0001.sh | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/fwts-test/rsdp-0001/test-0001.sh b/fwts-test/rsdp-0001/test-0001.sh
> index 4762059..1adaccf 100755
> --- a/fwts-test/rsdp-0001/test-0001.sh
> +++ b/fwts-test/rsdp-0001/test-0001.sh
> @@ -4,6 +4,16 @@ TEST="Test apcitables against broken ACPI RSDP"
>   NAME=test-0001.sh
>   TMPLOG=$TMP/rsdp.log.$$
>
> +machine=$(uname -m)
> +case $machine in
> +x86 | x86_32 | x86_64 | i686 | arm64 | aarch64)
> +	;;
> +*)
> +        echo SKIP: $TEST, $NAME
> +        exit 77
> +	;;
> +esac
> +
>   $FWTS --log-format="%line %owner " -w 80 --dumpfile=$FWTSTESTDIR/rsdp-0001/acpidump-0001.log rsdp - | cut -c7- | grep "^rsdp" > $TMPLOG
>   diff $TMPLOG $FWTSTESTDIR/rsdp-0001/rsdp.log >> $FAILURE_LOG
>   ret=$?
>

Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox

Patch

diff --git a/fwts-test/rsdp-0001/test-0001.sh b/fwts-test/rsdp-0001/test-0001.sh
index 4762059..1adaccf 100755
--- a/fwts-test/rsdp-0001/test-0001.sh
+++ b/fwts-test/rsdp-0001/test-0001.sh
@@ -4,6 +4,16 @@  TEST="Test apcitables against broken ACPI RSDP"
 NAME=test-0001.sh
 TMPLOG=$TMP/rsdp.log.$$
 
+machine=$(uname -m)
+case $machine in
+x86 | x86_32 | x86_64 | i686 | arm64 | aarch64)
+	;;
+*)
+        echo SKIP: $TEST, $NAME
+        exit 77
+	;;
+esac
+
 $FWTS --log-format="%line %owner " -w 80 --dumpfile=$FWTSTESTDIR/rsdp-0001/acpidump-0001.log rsdp - | cut -c7- | grep "^rsdp" > $TMPLOG
 diff $TMPLOG $FWTSTESTDIR/rsdp-0001/rsdp.log >> $FAILURE_LOG
 ret=$?