| Message ID | 1447173482-7825-1-git-send-email-al.stone@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 10/11/15 16:38, Al Stone wrote: > In a previous patch ("ACPI: MADT: update GICC flag checks for ACPI 6.0"), > I corrected the flag mask used in the if test, but failed to correct the > flag used in the fwts_failed() call that was part of the logic block. > > This patch fixes the mask for fwts_failed() so the test and failure message > are consistent again. > > Signed-off-by: Al Stone <al.stone@linaro.org> > --- > src/acpi/madt/madt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c > index 1f19848..31c6650 100644 > --- a/src/acpi/madt/madt.c > +++ b/src/acpi/madt/madt.c > @@ -232,7 +232,7 @@ static int madt_test1(fwts_framework *fw) > "MADTGICFLags", > "MADT GIC, flags, bits 2..31 are reserved " > "and should be zero, but are set as: %" PRIx32 ".", > - gic->flags & 0xfffffffc); > + gic->flags & 0xfffffff8); > } > skip = sizeof(fwts_acpi_madt_gic); > > Thanks Al, Acked-by: Colin Ian King <colin.king@canonical.com>
On 11/11/2015 12:38 AM, Al Stone wrote: > In a previous patch ("ACPI: MADT: update GICC flag checks for ACPI 6.0"), > I corrected the flag mask used in the if test, but failed to correct the > flag used in the fwts_failed() call that was part of the logic block. > > This patch fixes the mask for fwts_failed() so the test and failure message > are consistent again. > > Signed-off-by: Al Stone <al.stone@linaro.org> > --- > src/acpi/madt/madt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c > index 1f19848..31c6650 100644 > --- a/src/acpi/madt/madt.c > +++ b/src/acpi/madt/madt.c > @@ -232,7 +232,7 @@ static int madt_test1(fwts_framework *fw) > "MADTGICFLags", > "MADT GIC, flags, bits 2..31 are reserved " > "and should be zero, but are set as: %" PRIx32 ".", > - gic->flags & 0xfffffffc); > + gic->flags & 0xfffffff8); > } > skip = sizeof(fwts_acpi_madt_gic); > > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c index 1f19848..31c6650 100644 --- a/src/acpi/madt/madt.c +++ b/src/acpi/madt/madt.c @@ -232,7 +232,7 @@ static int madt_test1(fwts_framework *fw) "MADTGICFLags", "MADT GIC, flags, bits 2..31 are reserved " "and should be zero, but are set as: %" PRIx32 ".", - gic->flags & 0xfffffffc); + gic->flags & 0xfffffff8); } skip = sizeof(fwts_acpi_madt_gic);
In a previous patch ("ACPI: MADT: update GICC flag checks for ACPI 6.0"), I corrected the flag mask used in the if test, but failed to correct the flag used in the fwts_failed() call that was part of the logic block. This patch fixes the mask for fwts_failed() so the test and failure message are consistent again. Signed-off-by: Al Stone <al.stone@linaro.org> --- src/acpi/madt/madt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)