From patchwork Fri Oct 30 22:31:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Stone X-Patchwork-Id: 538541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 2FF59140D92; Sat, 31 Oct 2015 09:32:13 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro_org.20150623.gappssmtp.com header.i=@linaro_org.20150623.gappssmtp.com header.b=oxebTCZg; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1ZsIDS-0000jg-93; Fri, 30 Oct 2015 22:32:10 +0000 Received: from mail-pa0-f52.google.com ([209.85.220.52]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1ZsIDN-0000i4-44 for fwts-devel@lists.ubuntu.com; Fri, 30 Oct 2015 22:32:05 +0000 Received: by padhk11 with SMTP id hk11so86121880pad.1 for ; Fri, 30 Oct 2015 15:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=PwT5q5mNFzKBthyVCuvDhV1AzbvRRK4b5E077DfysAs=; b=oxebTCZgQL3Gn1wxtdftfhq7noGH++aYv4cCZe6QGopoKEx8ZfLhlcTWoXC4HRGsDb Z+P9AeH3UhpZydzPvscVXnra7WyY6tTdwLPeVlXbbrFzar0A39pGoG9kwzMMbzMmK+4z wGI5un3cPauZf2O+wwxOA/ziUHrn1G7P8LEa6mTQFhMztu3rvmGQ38PtrMeEi6wGJMtK i2IZK/5Ac2Vp4RTZCstwAYYfStnEJRlnToSjaKoZj/t+N0cc59cFUZHOE/WjW/0Levv0 bOBd3ORtETkmZifcZ73CW+dYqeKJKXvrFMgVI/UKNloHgxkHY9N2GAyH4I31H81XAzmp 4LWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PwT5q5mNFzKBthyVCuvDhV1AzbvRRK4b5E077DfysAs=; b=VFXHbf6ZSvebt4/yVqE8/2hWBQTIA0P7VuVrQS4aetT/RapeDuYkde1Bs042CYY58g RVYomcyOyQp1r2aDgu9Bl93MtWQGOd2VzUa+JvUb17kGqG4j0YSZQNvva8/WaUyQ1vJt vShyQaKzeILWQYc0XBt4Gh7wYeHxVbdkW0f+cTkFZM/kER8fht0BqLipw3KsXxd0uiuf +y6NYAovB1W6ewPjHKk/lQnq3gNCeBeuzEg1qhcEOIUlRNBxYHpPj2GQT0XxVBRMRK05 hbQvvsdkQkowTyAOqZKadOZbyXUu7xLRhyDtWV5uQI+X+7QUUvfCAZIg+vC2ny0tTKbM 41Sg== X-Gm-Message-State: ALoCoQnSbkshRSB76/IEiq9JQ4jmkjFGrQFljCXFcNmuCigXgWvi9HZMz/DGn8GtYv6tjUfbuBfJ X-Received: by 10.68.143.98 with SMTP id sd2mr11399822pbb.70.1446244324466; Fri, 30 Oct 2015 15:32:04 -0700 (PDT) Received: from fidelio.ahs3.com (c-50-134-239-249.hsd1.co.comcast.net. [50.134.239.249]) by smtp.googlemail.com with ESMTPSA id hl2sm10069778pbb.58.2015.10.30.15.32.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Oct 2015 15:32:02 -0700 (PDT) From: Al Stone To: fwts-devel@lists.ubuntu.com Subject: [PATCH] ACPI: MADT: update GICC flag checks for ACPI 6.0 Date: Fri, 30 Oct 2015 16:31:54 -0600 Message-Id: <1446244314-2317-1-git-send-email-al.stone@linaro.org> X-Mailer: git-send-email 2.4.3 Cc: patches@linaro.org, linaro-acpi@lists.linaro.org X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com In the ACPI 6.0 spec, the flags field of the MADT GICC subtable uses three bits, not two. Correct the flag mask to do the test properly. Signed-off-by: Al Stone Acked-by: Alex Hung Acked-by: Ivan Hu --- src/acpi/madt/madt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c index f776745..1f19848 100644 --- a/src/acpi/madt/madt.c +++ b/src/acpi/madt/madt.c @@ -226,7 +226,7 @@ static int madt_test1(fwts_framework *fw) "MADT GIC C Structure reserved field should be zero, " "instead got 0x%" PRIx32 ".", gic->reserved); } - if (gic->flags & 0xfffffffc) { + if (gic->flags & 0xfffffff8) { passed = false; fwts_failed(fw, LOG_LEVEL_MEDIUM, "MADTGICFLags",