Message ID | 1438001994-5922-1-git-send-email-colin.king@canonical.com |
---|---|
State | Accepted |
Headers | show |
On 07/27/2015 08:59 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > show tests full total is not correct as it double accounts for tests > that are under multiple categories. I am going to remove it because: > > 1. It is wrong > 2. It is more work than can be justified to fix it > 3. Probably nobody cares about it anyway > > I think less is more in this case. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log | 2 -- > src/lib/src/fwts_framework.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log > index 3fd9769..3d0906e 100644 > --- a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log > +++ b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log > @@ -827,5 +827,3 @@ UEFI tests: > Test UEFI RT service set variable interface stress test. > Test UEFI RT service query variable info interface stress test. > Test UEFI RT service get variable interface, invalid parameters. > - > -Total of 668 tests > diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c > index c3f1dea..b74d3e5 100644 > --- a/src/lib/src/fwts_framework.c > +++ b/src/lib/src/fwts_framework.c > @@ -330,8 +330,6 @@ static void fwts_framework_show_tests(fwts_framework *fw, const bool full) > fwts_list_free_items(&sorted, NULL); > } > } > - if (full) > - printf("\nTotal of %d tests\n", total); > } > > /* > Acked-by: Alex Hung <alex.hung@canonical.com>
On 2015年07月27日 20:59, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > show tests full total is not correct as it double accounts for tests > that are under multiple categories. I am going to remove it because: > > 1. It is wrong > 2. It is more work than can be justified to fix it > 3. Probably nobody cares about it anyway > > I think less is more in this case. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log | 2 -- > src/lib/src/fwts_framework.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log > index 3fd9769..3d0906e 100644 > --- a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log > +++ b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log > @@ -827,5 +827,3 @@ UEFI tests: > Test UEFI RT service set variable interface stress test. > Test UEFI RT service query variable info interface stress test. > Test UEFI RT service get variable interface, invalid parameters. > - > -Total of 668 tests > diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c > index c3f1dea..b74d3e5 100644 > --- a/src/lib/src/fwts_framework.c > +++ b/src/lib/src/fwts_framework.c > @@ -330,8 +330,6 @@ static void fwts_framework_show_tests(fwts_framework *fw, const bool full) > fwts_list_free_items(&sorted, NULL); > } > } > - if (full) > - printf("\nTotal of %d tests\n", total); > } > > /* Acked-by: Ivan Hu<ivan.hu@canonical.com>
diff --git a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log index 3fd9769..3d0906e 100644 --- a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log +++ b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log @@ -827,5 +827,3 @@ UEFI tests: Test UEFI RT service set variable interface stress test. Test UEFI RT service query variable info interface stress test. Test UEFI RT service get variable interface, invalid parameters. - -Total of 668 tests diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c index c3f1dea..b74d3e5 100644 --- a/src/lib/src/fwts_framework.c +++ b/src/lib/src/fwts_framework.c @@ -330,8 +330,6 @@ static void fwts_framework_show_tests(fwts_framework *fw, const bool full) fwts_list_free_items(&sorted, NULL); } } - if (full) - printf("\nTotal of %d tests\n", total); } /*