diff mbox

acpi: fadt: check RESET_REG_SUP before checking the reset register

Message ID 1437705706-3324-1-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung July 24, 2015, 2:41 a.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/fadt/fadt.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Colin Ian King July 24, 2015, 8:25 a.m. UTC | #1 
On 24/07/15 03:41, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/fadt/fadt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index abacdb5..8d06d97 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -305,6 +305,9 @@ static void acpi_table_check_fadt_reset(
>  	const fwts_acpi_table_fadt *fadt,
>  	bool *passed)
>  {
> +	if (!(fadt->flags & FADT_RESET_SUPPORTED))
> +		return;
> +
>  	if (fadt->header.length>=129) {
>  		if ((fadt->reset_reg.address_space_id != 0) &&
>  		    (fadt->reset_reg.address_space_id != 1) &&
> 

Thanks for re-checking the fadt tests Alex.

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu July 28, 2015, 2:33 a.m. UTC | #2 
On 2015年07月24日 10:41, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/acpi/fadt/fadt.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index abacdb5..8d06d97 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -305,6 +305,9 @@ static void acpi_table_check_fadt_reset(
>   	const fwts_acpi_table_fadt *fadt,
>   	bool *passed)
>   {
> +	if (!(fadt->flags & FADT_RESET_SUPPORTED))
> +		return;
> +
>   	if (fadt->header.length>=129) {
>   		if ((fadt->reset_reg.address_space_id != 0) &&
>   		    (fadt->reset_reg.address_space_id != 1) &&

Acked-by: Ivan Hu<ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
index abacdb5..8d06d97 100644
--- a/src/acpi/fadt/fadt.c
+++ b/src/acpi/fadt/fadt.c
@@ -305,6 +305,9 @@  static void acpi_table_check_fadt_reset(
 	const fwts_acpi_table_fadt *fadt,
 	bool *passed)
 {
+	if (!(fadt->flags & FADT_RESET_SUPPORTED))
+		return;
+
 	if (fadt->header.length>=129) {
 		if ((fadt->reset_reg.address_space_id != 0) &&
 		    (fadt->reset_reg.address_space_id != 1) &&