| Message ID | 1437640270-17610-1-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On 07/23/2015 04:31 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > acpi/iort/iort.c: In function 'iort_test1': > acpi/iort/iort.c:619:20: error: comparison between signed and > unsigned integer expressions [-Werror=sign-compare] > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/iort/iort.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/iort/iort.c b/src/acpi/iort/iort.c > index 874b7b3..05446c2 100644 > --- a/src/acpi/iort/iort.c > +++ b/src/acpi/iort/iort.c > @@ -616,7 +616,7 @@ static int iort_test1(fwts_framework *fw) > uint8_t *data_end; > uint32_t count; > > - if (table->length < (ssize_t)iort->header.length) { > + if (table->length < (size_t)iort->header.length) { > fwts_failed(fw, LOG_LEVEL_HIGH, > "IORTTooShort", > "IORT table incorrectly sized, IORT " > Acked-by: Alex Hung <alex.hung@canonical.com>
On 2015年07月23日 16:31, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > acpi/iort/iort.c: In function 'iort_test1': > acpi/iort/iort.c:619:20: error: comparison between signed and > unsigned integer expressions [-Werror=sign-compare] > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/iort/iort.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/iort/iort.c b/src/acpi/iort/iort.c > index 874b7b3..05446c2 100644 > --- a/src/acpi/iort/iort.c > +++ b/src/acpi/iort/iort.c > @@ -616,7 +616,7 @@ static int iort_test1(fwts_framework *fw) > uint8_t *data_end; > uint32_t count; > > - if (table->length < (ssize_t)iort->header.length) { > + if (table->length < (size_t)iort->header.length) { > fwts_failed(fw, LOG_LEVEL_HIGH, > "IORTTooShort", > "IORT table incorrectly sized, IORT " Acked-by: Ivan Hu<ivan.hu@canonical.com>
diff --git a/src/acpi/iort/iort.c b/src/acpi/iort/iort.c index 874b7b3..05446c2 100644 --- a/src/acpi/iort/iort.c +++ b/src/acpi/iort/iort.c @@ -616,7 +616,7 @@ static int iort_test1(fwts_framework *fw) uint8_t *data_end; uint32_t count; - if (table->length < (ssize_t)iort->header.length) { + if (table->length < (size_t)iort->header.length) { fwts_failed(fw, LOG_LEVEL_HIGH, "IORTTooShort", "IORT table incorrectly sized, IORT "