| Message ID | 1421175905-17035-30-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On 01/14/2015 03:04 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > cppcheck is picking up some minor style issues which can > be easily fixed: > > [src/lib/src/fwts_efi_module.c:33]: > (style) The scope of the variable 'buffer' can be reduced. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_efi_module.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_efi_module.c b/src/lib/src/fwts_efi_module.c > index 922d90b..e662d83 100644 > --- a/src/lib/src/fwts_efi_module.c > +++ b/src/lib/src/fwts_efi_module.c > @@ -30,10 +30,11 @@ static bool module_already_loaded = false; > static int check_module_loaded(void) > { > FILE *fp; > - char buffer[1024]; > > module_already_loaded = false; > if ((fp = fopen("/proc/modules", "r")) != NULL) { > + char buffer[1024]; > + > while (fgets(buffer, sizeof(buffer), fp) != NULL) { > if (strstr(buffer, "efi_runtime") != NULL) { > module_already_loaded = true; > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 01/14/2015 03:04 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > cppcheck is picking up some minor style issues which can > be easily fixed: > > [src/lib/src/fwts_efi_module.c:33]: > (style) The scope of the variable 'buffer' can be reduced. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_efi_module.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_efi_module.c b/src/lib/src/fwts_efi_module.c > index 922d90b..e662d83 100644 > --- a/src/lib/src/fwts_efi_module.c > +++ b/src/lib/src/fwts_efi_module.c > @@ -30,10 +30,11 @@ static bool module_already_loaded = false; > static int check_module_loaded(void) > { > FILE *fp; > - char buffer[1024]; > > module_already_loaded = false; > if ((fp = fopen("/proc/modules", "r")) != NULL) { > + char buffer[1024]; > + > while (fgets(buffer, sizeof(buffer), fp) != NULL) { > if (strstr(buffer, "efi_runtime") != NULL) { > module_already_loaded = true; > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/lib/src/fwts_efi_module.c b/src/lib/src/fwts_efi_module.c index 922d90b..e662d83 100644 --- a/src/lib/src/fwts_efi_module.c +++ b/src/lib/src/fwts_efi_module.c @@ -30,10 +30,11 @@ static bool module_already_loaded = false; static int check_module_loaded(void) { FILE *fp; - char buffer[1024]; module_already_loaded = false; if ((fp = fopen("/proc/modules", "r")) != NULL) { + char buffer[1024]; + while (fgets(buffer, sizeof(buffer), fp) != NULL) { if (strstr(buffer, "efi_runtime") != NULL) { module_already_loaded = true;