diff mbox

[10/46] acpi: pcc: reduce scope of variables

Message ID 1421175905-17035-11-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Jan. 13, 2015, 7:04 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

cppcheck is picking up some minor style issues which can
be easily fixed:

[src/acpi/pcc/pcc.c:410]:
	(style) The scope of the variable 'item' can be reduced.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/pcc/pcc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ivan Hu Jan. 15, 2015, 7:30 a.m. UTC | #1 
On 01/14/2015 03:04 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> cppcheck is picking up some minor style issues which can
> be easily fixed:
>
> [src/acpi/pcc/pcc.c:410]:
> 	(style) The scope of the variable 'item' can be reduced.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/pcc/pcc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
> index 0f01baa..94f9b9e 100644
> --- a/src/acpi/pcc/pcc.c
> +++ b/src/acpi/pcc/pcc.c
> @@ -407,7 +407,6 @@ static int pcc_test1(fwts_framework *fw)
>   {
>   	ACPI_BUFFER       buf;
>   	ACPI_STATUS	  ret;
> -	fwts_list_link	*item;
>   	fwts_list *pccs;
>   	static char *name = "PCCH";
>   	size_t name_len = strlen(name);
> @@ -421,6 +420,8 @@ static int pcc_test1(fwts_framework *fw)
>   	fwts_log_nl(fw);
>
>   	if ((pccs = fwts_acpi_object_get_names()) != NULL) {
> +		fwts_list_link	*item;
> +
>   		fwts_list_foreach(item, pccs) {
>   			char *pcc_name = fwts_list_data(char*, item);
>   			size_t len = strlen(pcc_name);
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Keng-Yu Lin Jan. 20, 2015, 6:49 a.m. UTC | #2 
On Wed, Jan 14, 2015 at 3:04 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> cppcheck is picking up some minor style issues which can
> be easily fixed:
>
> [src/acpi/pcc/pcc.c:410]:
>         (style) The scope of the variable 'item' can be reduced.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/pcc/pcc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
> index 0f01baa..94f9b9e 100644
> --- a/src/acpi/pcc/pcc.c
> +++ b/src/acpi/pcc/pcc.c
> @@ -407,7 +407,6 @@ static int pcc_test1(fwts_framework *fw)
>  {
>         ACPI_BUFFER       buf;
>         ACPI_STATUS       ret;
> -       fwts_list_link  *item;
>         fwts_list *pccs;
>         static char *name = "PCCH";
>         size_t name_len = strlen(name);
> @@ -421,6 +420,8 @@ static int pcc_test1(fwts_framework *fw)
>         fwts_log_nl(fw);
>
>         if ((pccs = fwts_acpi_object_get_names()) != NULL) {
> +               fwts_list_link  *item;
> +
>                 fwts_list_foreach(item, pccs) {
>                         char *pcc_name = fwts_list_data(char*, item);
>                         size_t len = strlen(pcc_name);
> --
> 2.1.4
>
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
index 0f01baa..94f9b9e 100644
--- a/src/acpi/pcc/pcc.c
+++ b/src/acpi/pcc/pcc.c
@@ -407,7 +407,6 @@  static int pcc_test1(fwts_framework *fw)
 {
 	ACPI_BUFFER       buf;
 	ACPI_STATUS	  ret;
-	fwts_list_link	*item;
 	fwts_list *pccs;
 	static char *name = "PCCH";
 	size_t name_len = strlen(name);
@@ -421,6 +420,8 @@  static int pcc_test1(fwts_framework *fw)
 	fwts_log_nl(fw);
 
 	if ((pccs = fwts_acpi_object_get_names()) != NULL) {
+		fwts_list_link	*item;
+
 		fwts_list_foreach(item, pccs) {
 			char *pcc_name = fwts_list_data(char*, item);
 			size_t len = strlen(pcc_name);