| Message ID | 1418192494-10965-1-git-send-email-phidias.chiang@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Dec 10, 2014 at 2:21 PM, Phidias Chiang <phidias.chiang@canonical.com> wrote: > Signed-off-by: Phidias Chiang <phidias.chiang@canonical.com> > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index d6a695e..a654130 100644 > --- a/README > +++ b/README > @@ -6,7 +6,7 @@ Quick Start Guide > > 1) Dependencies: > > - autoconf, automake, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms > + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms > > 2) To build and install (only if building from source) > > -- > 2.1.0 > Acked-by: Keng-Yu Lin <kengyu@canonical.com>
On 10/12/14 07:04, Keng-Yu Lin wrote: > On Wed, Dec 10, 2014 at 2:21 PM, Phidias Chiang > <phidias.chiang@canonical.com> wrote: >> Signed-off-by: Phidias Chiang <phidias.chiang@canonical.com> >> --- >> README | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/README b/README >> index d6a695e..a654130 100644 >> --- a/README >> +++ b/README >> @@ -6,7 +6,7 @@ Quick Start Guide >> >> 1) Dependencies: >> >> - autoconf, automake, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms >> + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms >> >> 2) To build and install (only if building from source) >> >> -- >> 2.1.0 >> > > Acked-by: Keng-Yu Lin <kengyu@canonical.com> > Thanks Phidias, Has this been test built on the older releases we support? Colin
No, but I'm just adding a missing dependency in READEM file, I don't think that will affect any older release. On Thu, Dec 11, 2014 at 7:31 AM, Colin Ian King <colin.king@canonical.com> wrote: > On 10/12/14 07:04, Keng-Yu Lin wrote: > > On Wed, Dec 10, 2014 at 2:21 PM, Phidias Chiang > > <phidias.chiang@canonical.com> wrote: > >> Signed-off-by: Phidias Chiang <phidias.chiang@canonical.com> > >> --- > >> README | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/README b/README > >> index d6a695e..a654130 100644 > >> --- a/README > >> +++ b/README > >> @@ -6,7 +6,7 @@ Quick Start Guide > >> > >> 1) Dependencies: > >> > >> - autoconf, automake, libtool, libpcre3-dev, libjson0-dev, flex, > bison, dkms > >> + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, > libjson0-dev, flex, bison, dkms > >> > >> 2) To build and install (only if building from source) > >> > >> -- > >> 2.1.0 > >> > > > > Acked-by: Keng-Yu Lin <kengyu@canonical.com> > > > Thanks Phidias, > > Has this been test built on the older releases we support? > > Colin > > -- > fwts-devel mailing list > fwts-devel@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/fwts-devel >
On 12/10/2014 02:21 PM, Phidias Chiang wrote: > Signed-off-by: Phidias Chiang <phidias.chiang@canonical.com> > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index d6a695e..a654130 100644 > --- a/README > +++ b/README > @@ -6,7 +6,7 @@ Quick Start Guide > > 1) Dependencies: > > - autoconf, automake, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms > + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms > > 2) To build and install (only if building from source) > > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/README b/README index d6a695e..a654130 100644 --- a/README +++ b/README @@ -6,7 +6,7 @@ Quick Start Guide 1) Dependencies: - autoconf, automake, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms 2) To build and install (only if building from source)
Signed-off-by: Phidias Chiang <phidias.chiang@canonical.com> --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)