diff mbox

Remove the x86 specific build constraints for dmicheck

Message ID 1413638353-4308-1-git-send-email-colin.king@canonical.com
State Rejected
Headers show

Commit Message

Colin Ian King Oct. 18, 2014, 1:19 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Appartently some arm64 systems are being enabled with DMI tables
so enable this test for these systems.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Alex Hung Oct. 19, 2014, 5:08 a.m. UTC | #1 
On 14-10-18 09:19 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Appartently some arm64 systems are being enabled with DMI tables
> so enable this test for these systems.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/dmi/dmicheck/dmicheck.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index e6dee6e..6753a83 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -24,8 +24,6 @@
>   
>   #include "fwts.h"
>   
> -#ifdef FWTS_ARCH_INTEL
> -
>   #include <stdlib.h>
>   #include <stdio.h>
>   #include <string.h>
> @@ -1591,5 +1589,3 @@ static fwts_framework_ops dmicheck_ops = {
>   };
>   
>   FWTS_REGISTER("dmicheck", &dmicheck_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV)
> -
> -#endif

Yes I also heard that ARM platforms are also implementing DMI.

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin Oct. 20, 2014, 4:25 a.m. UTC | #2 
On Sun, Oct 19, 2014 at 1:08 PM, Alex Hung <alex.hung@canonical.com> wrote:
>
> On 14-10-18 09:19 PM, Colin King wrote:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Appartently some arm64 systems are being enabled with DMI tables
>> so enable this test for these systems.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>   src/dmi/dmicheck/dmicheck.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
>> index e6dee6e..6753a83 100644
>> --- a/src/dmi/dmicheck/dmicheck.c
>> +++ b/src/dmi/dmicheck/dmicheck.c
>> @@ -24,8 +24,6 @@
>>     #include "fwts.h"
>>   -#ifdef FWTS_ARCH_INTEL
>> -
>>   #include <stdlib.h>
>>   #include <stdio.h>
>>   #include <string.h>
>> @@ -1591,5 +1589,3 @@ static fwts_framework_ops dmicheck_ops = {
>>   };
>>     FWTS_REGISTER("dmicheck", &dmicheck_ops, FWTS_TEST_ANYTIME,
>> FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV)
>> -
>> -#endif
>
>
> Yes I also heard that ARM platforms are also implementing DMI.
>
> Acked-by: Alex Hung <alex.hung@canonical.com>
>

interesting to know this.


Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Colin Ian King Oct. 20, 2014, 8:04 a.m. UTC | #3 
I've had an update from Linaro. I'll send their patch instead.


On 20/10/14 05:25, Keng-Yu Lin wrote:
> On Sun, Oct 19, 2014 at 1:08 PM, Alex Hung <alex.hung@canonical.com> wrote:
>>
>> On 14-10-18 09:19 PM, Colin King wrote:
>>>
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Appartently some arm64 systems are being enabled with DMI tables
>>> so enable this test for these systems.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>>   src/dmi/dmicheck/dmicheck.c | 4 ----
>>>   1 file changed, 4 deletions(-)
>>>
>>> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
>>> index e6dee6e..6753a83 100644
>>> --- a/src/dmi/dmicheck/dmicheck.c
>>> +++ b/src/dmi/dmicheck/dmicheck.c
>>> @@ -24,8 +24,6 @@
>>>     #include "fwts.h"
>>>   -#ifdef FWTS_ARCH_INTEL
>>> -
>>>   #include <stdlib.h>
>>>   #include <stdio.h>
>>>   #include <string.h>
>>> @@ -1591,5 +1589,3 @@ static fwts_framework_ops dmicheck_ops = {
>>>   };
>>>     FWTS_REGISTER("dmicheck", &dmicheck_ops, FWTS_TEST_ANYTIME,
>>> FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV)
>>> -
>>> -#endif
>>
>>
>> Yes I also heard that ARM platforms are also implementing DMI.
>>
>> Acked-by: Alex Hung <alex.hung@canonical.com>
>>
> 
> interesting to know this.
> 
> 
> Acked-by: Keng-Yu Lin <kengyu@canonical.com>
>
Colin Ian King Oct. 20, 2014, 8:13 a.m. UTC | #4 
On 19/10/14 06:08, Alex Hung wrote:
> 
> On 14-10-18 09:19 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Appartently some arm64 systems are being enabled with DMI tables
>> so enable this test for these systems.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>   src/dmi/dmicheck/dmicheck.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
>> index e6dee6e..6753a83 100644
>> --- a/src/dmi/dmicheck/dmicheck.c
>> +++ b/src/dmi/dmicheck/dmicheck.c
>> @@ -24,8 +24,6 @@
>>     #include "fwts.h"
>>   -#ifdef FWTS_ARCH_INTEL
>> -
>>   #include <stdlib.h>
>>   #include <stdio.h>
>>   #include <string.h>
>> @@ -1591,5 +1589,3 @@ static fwts_framework_ops dmicheck_ops = {
>>   };
>>     FWTS_REGISTER("dmicheck", &dmicheck_ops, FWTS_TEST_ANYTIME,
>> FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV)
>> -
>> -#endif
> 
> Yes I also heard that ARM platforms are also implementing DMI.
> 
> Acked-by: Alex Hung <alex.hung@canonical.com>
> 

Please don't include this in fwts, I'll be sending a patch from Linaro
in a short while.

Colin
diff mbox

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index e6dee6e..6753a83 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -24,8 +24,6 @@ 
 
 #include "fwts.h"
 
-#ifdef FWTS_ARCH_INTEL
-
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
@@ -1591,5 +1589,3 @@  static fwts_framework_ops dmicheck_ops = {
 };
 
 FWTS_REGISTER("dmicheck", &dmicheck_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV)
-
-#endif