From patchwork Fri Mar 28 12:17:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 334682 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id D980D14007B for ; Fri, 28 Mar 2014 23:17:48 +1100 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WTVjH-0000bw-Qp; Fri, 28 Mar 2014 12:17:47 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WTVj4-0000b2-Kl for fwts-devel@lists.ubuntu.com; Fri, 28 Mar 2014 12:17:34 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginm.net ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1WTVj4-0006Mf-HI for fwts-devel@lists.ubuntu.com; Fri, 28 Mar 2014 12:17:34 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 2/2] acpi: acpitables: better checking on FADT SCI_INT Date: Fri, 28 Mar 2014 12:17:32 +0000 Message-Id: <1396009052-3915-3-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1396009052-3915-1-git-send-email-colin.king@canonical.com> References: <1396009052-3915-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King A SCI_INT failure should only be checked for if SMM is enabled, that is, if SMI_CMD is defined. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/acpi/acpitables/acpitables.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c index 9e562f6..439df2a 100644 --- a/src/acpi/acpitables/acpitables.c +++ b/src/acpi/acpitables/acpitables.c @@ -121,15 +121,25 @@ static void acpi_table_check_fadt(fwts_framework *fw, fwts_acpi_table_info *tabl } } - if (fadt->sci_int == 0) - fwts_failed(fw, LOG_LEVEL_MEDIUM, "FADTSCIIRQZero", "FADT SCI Interrupt is 0x00, should be defined."); - if (fadt->smi_cmd == 0) { + /* + * Section 5.2.9 (Fixed ACPI Description Table) of the ACPI 5.0 + * specification states that if SMI_CMD is zero then it is + * a system that does not support System Management Mode, so + * in that case, don't check SCI_INT being valid. + */ + if (fadt->smi_cmd != 0) { + if (fadt->sci_int == 0) { + fwts_failed(fw, LOG_LEVEL_MEDIUM, "FADTSCIIRQZero", "FADT SCI Interrupt is 0x00, should be defined."); + } + } else { if ((fadt->acpi_enable == 0) && (fadt->acpi_disable == 0) && (fadt->s4bios_req == 0) && (fadt->pstate_cnt == 0) && - (fadt->cst_cnt == 0)) - fwts_warning(fw, "FADT SMI_CMD is 0x00, system appears to not support System Management mode."); + (fadt->cst_cnt == 0)) { + /* Not an error, but intentional, but feedback this finding anyhow */ + fwts_log_info(fw, "The FADT SMI_CMD is zero, system does not support System Management Mode."); + } else { fwts_failed(fw, LOG_LEVEL_MEDIUM, "FADTSMICMDZero", "FADT SMI_CMD is 0x00, however, one or more of ACPI_ENABLE, ACPI_DISABLE, "