From patchwork Wed Jan 22 12:24:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 313219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 93D4A2C00A6 for ; Wed, 22 Jan 2014 23:24:58 +1100 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1W5wrX-0001Ee-7S; Wed, 22 Jan 2014 12:24:55 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1W5wrQ-0001EQ-5A for fwts-devel@lists.ubuntu.com; Wed, 22 Jan 2014 12:24:48 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginm.net ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1W5wrQ-0002QG-2j for fwts-devel@lists.ubuntu.com; Wed, 22 Jan 2014 12:24:48 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] Allow for RSDP that is not 16 byte aligned (LP: #1271522) Date: Wed, 22 Jan 2014 12:24:47 +0000 Message-Id: <1390393487-5881-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.5.3 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Commit 94ea2aa606a8115325e5c5781a958c4eb9ce856b presumed that the RSDP is 16 byte aligned. However, UEFI systems don't seem to apply to this old BIOS rule of thumb, so relax this constraint. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/src/fwts_acpi_tables.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c index b226e51..ca3b34a 100644 --- a/src/lib/src/fwts_acpi_tables.c +++ b/src/lib/src/fwts_acpi_tables.c @@ -295,10 +295,6 @@ static int fwts_acpi_load_tables_from_firmware(fwts_framework *fw) if (!rsdp_addr) return FWTS_ERROR; - /* Must be on a 16 byte boundary */ - if (((unsigned long)rsdp_addr & 0xf)) - return FWTS_ERROR; - /* Load and save cached RSDP */ if ((rsdp = fwts_acpi_get_rsdp(rsdp_addr, &rsdp_len)) == NULL) return FWTS_ERROR;