diff mbox

ACPICA:enable 64bit build for aarch64 architecture

Message ID 1376465164-2222-1-git-send-email-naresh.bhat@linaro.org
State Rejected
Headers show

Commit Message

Naresh Bhat Aug. 14, 2013, 7:26 a.m. UTC 
From: Naresh Bhat <naresh.bhat@linaro.org>

Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>

Enable 64 bit build for aarch64 architecture in ACPICA Linux
platform specific defines.
---
 src/acpica/source/include/platform/aclinux.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Naresh Bhat Aug. 14, 2013, 5:11 p.m. UTC | #1 
Hi,

There is typo error ..:( in the patch (__aarch64__) which should be
defined(__aarch64__) I have corrected it and resend the patch.

Regards
-Naresh Bhat

On 14 August 2013 12:56,  <naresh.bhat@linaro.org> wrote:
> From: Naresh Bhat <naresh.bhat@linaro.org>
>
> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
>
> Enable 64 bit build for aarch64 architecture in ACPICA Linux
> platform specific defines.
> ---
>  src/acpica/source/include/platform/aclinux.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h
> index e561292..6b8b1ab 100644
> --- a/src/acpica/source/include/platform/aclinux.h
> +++ b/src/acpica/source/include/platform/aclinux.h
> @@ -159,7 +159,7 @@
>  #define ACPI_FLUSH_CPU_CACHE()
>  #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
>
> -#if defined(__ia64__) || defined(__x86_64__)
> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
>  #define ACPI_MACHINE_WIDTH          64
>  #define COMPILER_DEPENDENT_INT64    long
>  #define COMPILER_DEPENDENT_UINT64   unsigned long
> --
> 1.7.9.5
>
Ivan Hu Aug. 18, 2013, 11:07 p.m. UTC | #2 
On 08/14/2013 03:26 PM, naresh.bhat@linaro.org wrote:
> From: Naresh Bhat <naresh.bhat@linaro.org>
>
> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
>
> Enable 64 bit build for aarch64 architecture in ACPICA Linux
> platform specific defines.
> ---
>   src/acpica/source/include/platform/aclinux.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h
> index e561292..6b8b1ab 100644
> --- a/src/acpica/source/include/platform/aclinux.h
> +++ b/src/acpica/source/include/platform/aclinux.h
> @@ -159,7 +159,7 @@
>   #define ACPI_FLUSH_CPU_CACHE()
>   #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
>
> -#if defined(__ia64__) || defined(__x86_64__)
> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
>   #define ACPI_MACHINE_WIDTH          64
>   #define COMPILER_DEPENDENT_INT64    long
>   #define COMPILER_DEPENDENT_UINT64   unsigned long
>

Hi Naresh,

Thanks for working on this.
I don't have the arm 64-bits platform could test.:)
But checking with x86 64 and 32 bits, arm 32 bit, the patch doesn't 
break these builds.

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Ivan Hu Aug. 18, 2013, 11:11 p.m. UTC | #3 
Sorry, ACKed the wrong patch.

Ivan


On 08/19/2013 07:07 AM, IvanHu wrote:
> On 08/14/2013 03:26 PM, naresh.bhat@linaro.org wrote:
>> From: Naresh Bhat <naresh.bhat@linaro.org>
>>
>> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
>>
>> Enable 64 bit build for aarch64 architecture in ACPICA Linux
>> platform specific defines.
>> ---
>>   src/acpica/source/include/platform/aclinux.h |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/acpica/source/include/platform/aclinux.h
>> b/src/acpica/source/include/platform/aclinux.h
>> index e561292..6b8b1ab 100644
>> --- a/src/acpica/source/include/platform/aclinux.h
>> +++ b/src/acpica/source/include/platform/aclinux.h
>> @@ -159,7 +159,7 @@
>>   #define ACPI_FLUSH_CPU_CACHE()
>>   #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
>>
>> -#if defined(__ia64__) || defined(__x86_64__)
>> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
>>   #define ACPI_MACHINE_WIDTH          64
>>   #define COMPILER_DEPENDENT_INT64    long
>>   #define COMPILER_DEPENDENT_UINT64   unsigned long
>>
>
> Hi Naresh,
>
> Thanks for working on this.
> I don't have the arm 64-bits platform could test.:)
> But checking with x86 64 and 32 bits, arm 32 bit, the patch doesn't
> break these builds.
>
> Acked-by: Ivan Hu <ivan.hu@canonical.com>
Naresh Bhat Aug. 19, 2013, 5:18 a.m. UTC | #4 
Hi Ivan Hu,

I have send one more patch with correction.  Please acknowledge the
same.  BTW same changes created against the ACPICA git repository got
merged by "Robert Moore" into acpica git reposiotry

https://github.com/acpica/acpica/commit/d85cf98594da99b582aa47d04f01fd81112ae448


Thanks and Regards
-Naresh Bhat

On 19 August 2013 04:41, IvanHu <ivan.hu@canonical.com> wrote:
> Sorry, ACKed the wrong patch.
>
> Ivan
>
>
> On 08/19/2013 07:07 AM, IvanHu wrote:
>>
>> On 08/14/2013 03:26 PM, naresh.bhat@linaro.org wrote:
>>>
>>> From: Naresh Bhat <naresh.bhat@linaro.org>
>>>
>>> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
>>>
>>> Enable 64 bit build for aarch64 architecture in ACPICA Linux
>>> platform specific defines.
>>> ---
>>>   src/acpica/source/include/platform/aclinux.h |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/acpica/source/include/platform/aclinux.h
>>> b/src/acpica/source/include/platform/aclinux.h
>>> index e561292..6b8b1ab 100644
>>> --- a/src/acpica/source/include/platform/aclinux.h
>>> +++ b/src/acpica/source/include/platform/aclinux.h
>>> @@ -159,7 +159,7 @@
>>>   #define ACPI_FLUSH_CPU_CACHE()
>>>   #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
>>>
>>> -#if defined(__ia64__) || defined(__x86_64__)
>>> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
>>>   #define ACPI_MACHINE_WIDTH          64
>>>   #define COMPILER_DEPENDENT_INT64    long
>>>   #define COMPILER_DEPENDENT_UINT64   unsigned long
>>>
>>
>> Hi Naresh,
>>
>> Thanks for working on this.
>> I don't have the arm 64-bits platform could test.:)
>> But checking with x86 64 and 32 bits, arm 32 bit, the patch doesn't
>> break these builds.
>>
>> Acked-by: Ivan Hu <ivan.hu@canonical.com>
>
>
diff mbox

Patch

diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h
index e561292..6b8b1ab 100644
--- a/src/acpica/source/include/platform/aclinux.h
+++ b/src/acpica/source/include/platform/aclinux.h
@@ -159,7 +159,7 @@ 
 #define ACPI_FLUSH_CPU_CACHE()
 #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
 
-#if defined(__ia64__) || defined(__x86_64__)
+#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
 #define ACPI_MACHINE_WIDTH          64
 #define COMPILER_DEPENDENT_INT64    long
 #define COMPILER_DEPENDENT_UINT64   unsigned long