From patchwork Mon Jul 8 15:56:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 257566 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 48A802C02EB for ; Tue, 9 Jul 2013 01:56:47 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UwDny-0000x4-5l; Mon, 08 Jul 2013 15:56:46 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UwDns-0000wz-LM for fwts-devel@lists.ubuntu.com; Mon, 08 Jul 2013 15:56:40 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UwDns-0004ki-I9 for fwts-devel@lists.ubuntu.com; Mon, 08 Jul 2013 15:56:40 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] checksum-0001: fix diff return check Date: Mon, 8 Jul 2013 16:56:40 +0100 Message-Id: <1373299000-32211-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Commit 25e82837d8f01dd7928c435082d42e5086073345 introduced a bug in checking for the diff return. This appeared during some debugging I did and I somehow foolishly checked this in. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Alex Hung --- checksum-0001/test-0001.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/checksum-0001/test-0001.sh b/checksum-0001/test-0001.sh index 89aa14a..79dcd73 100755 --- a/checksum-0001/test-0001.sh +++ b/checksum-0001/test-0001.sh @@ -6,9 +6,8 @@ TMPLOG=$TMP/checksum.log.$$ $FWTS --log-format="%line %owner " -w 120 --dumpfile=acpidump-0001.log checksum - | grep "^[0-9]*[ ]*checksum" | grep -v RSDP | cut -c7- > $TMPLOG diff $TMPLOG checksum-0001.log >> $FAILURE_LOG -cp $TMPLOG checksum-0001.log ret=$? -if [ $ret -eq 0 ]; then +if [ $ret -eq 0 ]; then echo PASSED: $TEST, $NAME else echo FAILED: $TEST, $NAME