From patchwork Wed Feb 27 14:40:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 223617 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 51E6C2C0090 for ; Thu, 28 Feb 2013 01:41:03 +1100 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UAiBp-0002ST-SB; Wed, 27 Feb 2013 14:41:01 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UAiBm-0002RY-7U for fwts-devel@lists.ubuntu.com; Wed, 27 Feb 2013 14:40:58 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UAiBm-0006Lr-5R for fwts-devel@lists.ubuntu.com; Wed, 27 Feb 2013 14:40:58 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 8/8] data: syntaxcheck: add a few more advice entries Date: Wed, 27 Feb 2013 14:40:54 +0000 Message-Id: <1361976054-28357-9-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1361976054-28357-1-git-send-email-colin.king@canonical.com> References: <1361976054-28357-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Add some missing advice entries for some more specific errors Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- data/syntaxcheck.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/data/syntaxcheck.json b/data/syntaxcheck.json index e9c61ea..b3ceb55 100644 --- a/data/syntaxcheck.json +++ b/data/syntaxcheck.json @@ -2,6 +2,22 @@ "erroradvice": [ { + "id": "ASL_MSG_RETURN_TYPES", + "advice": "Some of the execution paths do not return a value. All control paths that return must return a value otherwise unepected behaviour may occur. This error occurs because a branch on an conditional op-code returns a value and another does not, which is inconsitent behaviour." + }, + { + "id": "ASL_MSG_RESERVED_RETURN_VALUE", + "advice": "A reserved method was expected to return a value, however, it does not. This is unexpected behaviour that does not conform the the ACPI specification." + }, + { + "id": "ASL_MSG_INVALID_TYPE", + "advice": "An invalid type was used. A different type was expected to be used.", + }, + { + "id": "ASL_MSG_RESERVED_NO_RETURN_VAL", + "advice": "A reserved method returned a value however it is not expected to return anything, so this does not conform to the expected behaviour. The kernel will most probably ignore the return value, so this is not going to produce any run time errors." + }, + { "id": "ASL_MSG_ALIGNMENT", "advice": "Addresses must be an exact multiple of the alignment value." },