From patchwork Sun Oct 14 20:32:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 191412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 15EFD2C008A for ; Mon, 15 Oct 2012 07:32:36 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TNUrS-0006Dm-Tq; Sun, 14 Oct 2012 20:32:34 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TNUrQ-0006Ce-2I for fwts-devel@lists.ubuntu.com; Sun, 14 Oct 2012 20:32:32 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TNUrP-0003sj-WD for fwts-devel@lists.ubuntu.com; Sun, 14 Oct 2012 20:32:32 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 24/26] uefi: uefidump: cast to ptrdiff_t to remove mixed signed/unsigned comparison Date: Sun, 14 Oct 2012 21:32:16 +0100 Message-Id: <1350246738-31699-25-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1350246738-31699-1-git-send-email-colin.king@canonical.com> References: <1350246738-31699-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King We shouldn't be comparing a ptrdiff_t to a size_t, so cast to avoid a signed/unsigned comparison. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/uefi/uefidump/uefidump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c index 11c40e9..d09db0b 100644 --- a/src/uefi/uefidump/uefidump.c +++ b/src/uefi/uefidump/uefidump.c @@ -16,6 +16,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. * */ +#include #include #include "fwts.h" @@ -645,7 +646,7 @@ static void uefidump_info_signature_support(fwts_framework *fw, fwts_uefi_var *v if (var->datalen) fwts_log_info_verbatum(fw, " Signature GUIDs:"); - while (data - var->data < var->datalen) { + while (data - var->data < (ptrdiff_t)var->datalen) { fwts_guid_buf_to_str(data, guid_str, sizeof(guid_str)); fwts_log_info_verbatum(fw, " %s", guid_str); data += 16;