From patchwork Sun Oct 14 20:32:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 191411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id B81772C009B for ; Mon, 15 Oct 2012 07:32:35 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TNUrS-0006Dc-Ez; Sun, 14 Oct 2012 20:32:34 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TNUrO-0006Bz-JL for fwts-devel@lists.ubuntu.com; Sun, 14 Oct 2012 20:32:30 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TNUrO-0003sa-F4 for fwts-devel@lists.ubuntu.com; Sun, 14 Oct 2012 20:32:30 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 21/26] cpu: maxfreq: remove redundant init and deinit functions Date: Sun, 14 Oct 2012 21:32:13 +0100 Message-Id: <1350246738-31699-22-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1350246738-31699-1-git-send-email-colin.king@canonical.com> References: <1350246738-31699-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King We can remove redundant maxfreq_init and maxfreq_deinit functions - if they are null then we don't need to call them at start and completion of the test. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/cpu/maxfreq/maxfreq.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/cpu/maxfreq/maxfreq.c b/src/cpu/maxfreq/maxfreq.c index 16a8732..bc70fc9 100644 --- a/src/cpu/maxfreq/maxfreq.c +++ b/src/cpu/maxfreq/maxfreq.c @@ -28,16 +28,6 @@ #define CPU_FREQ_PATH "/sys/devices/system/cpu" #define CPU_INFO_PATH "/proc/cpuinfo" -static int maxfreq_init(fwts_framework *fw) -{ - return FWTS_OK; -} - -static int maxfreq_deinit(fwts_framework *fw) -{ - return FWTS_OK; -} - typedef struct { int cpu; int speed; @@ -199,8 +189,6 @@ static fwts_framework_minor_test maxfreq_tests[] = { static fwts_framework_ops maxfreq_ops = { .description = "Check max CPU frequencies against max scaling frequency.", - .init = maxfreq_init, - .deinit = maxfreq_deinit, .minor_tests = maxfreq_tests };