diff mbox

[15/17] fedfsd: Fix missing break

Message ID 20140527153830.1177.14657.stgit@seurat.1015granger.net
State Accepted
Headers show

Commit Message

Chuck Lever May 27, 2014, 3:38 p.m. UTC 
Avoid using fallthrough logic in switch statements.

Fixes: 0520ee7207f9ba027c845cb33606a3c901ecd811
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 src/fedfsc/fedfs-create-junction.c         |    3 ++-
 src/fedfsc/fedfs-create-replication.c      |    3 ++-
 src/fedfsc/fedfs-delete-junction.c         |    3 ++-
 src/fedfsc/fedfs-delete-replication.c      |    3 ++-
 src/fedfsc/fedfs-get-limited-nsdb-params.c |    3 ++-
 src/fedfsc/fedfs-get-nsdb-params.c         |    3 ++-
 src/fedfsc/fedfs-lookup-junction.c         |    3 ++-
 src/fedfsc/fedfs-lookup-replication.c      |    3 ++-
 src/fedfsc/fedfs-null.c                    |    3 ++-
 src/fedfsc/fedfs-set-nsdb-params.c         |    3 ++-
 10 files changed, 20 insertions(+), 10 deletions(-)
diff mbox

Patch

diff --git a/src/fedfsc/fedfs-create-junction.c b/src/fedfsc/fedfs-create-junction.c
index 0d6ce2d9edcd..4999b0a06b69 100644
--- a/src/fedfsc/fedfs-create-junction.c
+++ b/src/fedfsc/fedfs-create-junction.c
@@ -236,10 +236,11 @@  main(int argc, char **argv)
 				fedfs_create_junction_usage(progname);
 			}
 			break;
+		case '?':
+			fedfs_create_junction_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			fedfs_create_junction_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-create-replication.c b/src/fedfsc/fedfs-create-replication.c
index 3267627aa6c1..93a973225ace 100644
--- a/src/fedfsc/fedfs-create-replication.c
+++ b/src/fedfsc/fedfs-create-replication.c
@@ -233,10 +233,11 @@  main(int argc, char **argv)
 				fedfs_create_replication_usage(progname);
 			}
 			break;
+		case '?':
+			fedfs_create_replication_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			fedfs_create_replication_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-delete-junction.c b/src/fedfsc/fedfs-delete-junction.c
index f2085c5992a2..0aa8a7fa344d 100644
--- a/src/fedfsc/fedfs-delete-junction.c
+++ b/src/fedfsc/fedfs-delete-junction.c
@@ -184,9 +184,10 @@  main(int argc, char **argv)
 		case 'h':
 			hostname = optarg;
 			break;
+		case '?':
+			fedfs_delete_junction_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_delete_junction_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-delete-replication.c b/src/fedfsc/fedfs-delete-replication.c
index ee0a6bda406d..42ad812ba094 100644
--- a/src/fedfsc/fedfs-delete-replication.c
+++ b/src/fedfsc/fedfs-delete-replication.c
@@ -187,9 +187,10 @@  main(int argc, char **argv)
 		case 'p':
 			path = optarg;
 			break;
+		case '?':
+			fedfs_delete_replication_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_delete_replication_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-get-limited-nsdb-params.c b/src/fedfsc/fedfs-get-limited-nsdb-params.c
index 3d10aa099cfa..40f88f56acfa 100644
--- a/src/fedfsc/fedfs-get-limited-nsdb-params.c
+++ b/src/fedfsc/fedfs-get-limited-nsdb-params.c
@@ -232,9 +232,10 @@  main(int argc, char **argv)
 				fedfs_get_limited_nsdb_params_usage(progname);
 			}
 			break;
+		case '?':
+			fedfs_get_limited_nsdb_params_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_get_limited_nsdb_params_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-get-nsdb-params.c b/src/fedfsc/fedfs-get-nsdb-params.c
index a77cf88786eb..6980d37b4467 100644
--- a/src/fedfsc/fedfs-get-nsdb-params.c
+++ b/src/fedfsc/fedfs-get-nsdb-params.c
@@ -249,9 +249,10 @@  main(int argc, char **argv)
 				fedfs_get_nsdb_params_usage(progname);
 			}
 			break;
+		case '?':
+			fedfs_get_nsdb_params_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_get_nsdb_params_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-lookup-junction.c b/src/fedfsc/fedfs-lookup-junction.c
index f62691e47b81..8bd77d573ba0 100644
--- a/src/fedfsc/fedfs-lookup-junction.c
+++ b/src/fedfsc/fedfs-lookup-junction.c
@@ -394,9 +394,10 @@  main(int argc, char **argv)
 		case 't':
 			resolvetype = optarg;
 			break;
+		case '?':
+			fedfs_lookup_junction_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_lookup_junction_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-lookup-replication.c b/src/fedfsc/fedfs-lookup-replication.c
index a845b320ab55..93db2caf1a14 100644
--- a/src/fedfsc/fedfs-lookup-replication.c
+++ b/src/fedfsc/fedfs-lookup-replication.c
@@ -399,9 +399,10 @@  main(int argc, char **argv)
 		case 't':
 			resolvetype = optarg;
 			break;
+		case '?':
+			fedfs_lookup_replication_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_lookup_replication_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-null.c b/src/fedfsc/fedfs-null.c
index 05cf9a99d8a5..de1d5d503ef2 100644
--- a/src/fedfsc/fedfs-null.c
+++ b/src/fedfsc/fedfs-null.c
@@ -162,9 +162,10 @@  main(int argc, char **argv)
 		case 'n':
 			nettype = optarg;
 			break;
+		case '?':
+			fedfs_null_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_null_usage(progname);
 		}
 	}
diff --git a/src/fedfsc/fedfs-set-nsdb-params.c b/src/fedfsc/fedfs-set-nsdb-params.c
index 783f04536586..447573c461a6 100644
--- a/src/fedfsc/fedfs-set-nsdb-params.c
+++ b/src/fedfsc/fedfs-set-nsdb-params.c
@@ -250,9 +250,10 @@  main(int argc, char **argv)
 				fedfs_set_nsdb_params_usage(progname);
 			}
 			break;
+		case '?':
+			fedfs_set_nsdb_params_usage(progname);
 		default:
 			fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
-		case '?':
 			fedfs_set_nsdb_params_usage(progname);
 		}
 	}