From patchwork Tue May 27 15:38:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 353024 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B5E691400E0 for ; Wed, 28 May 2014 01:38:45 +1000 (EST) Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4RFcgib017957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 May 2014 15:38:43 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4RFcgCG009809 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 27 May 2014 15:38:42 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1WpJSc-0004hU-5h; Tue, 27 May 2014 08:38:42 -0700 Received: from ucsinet21.oracle.com ([156.151.31.93]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1WpJSL-0004gk-78 for fedfs-utils-devel@oss.oracle.com; Tue, 27 May 2014 08:38:25 -0700 Received: from aserp1020.oracle.com (aserp1020.oracle.com [141.146.126.67]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4RFcO9x001052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 27 May 2014 15:38:24 GMT Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com [209.85.223.173]) by aserp1020.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4RFcNlj028246 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Tue, 27 May 2014 15:38:23 GMT Authentication-Results: aserp1020.oracle.com; dkim=pass reason="2048-bit key" header.d=gmail.com header.i=@gmail.com header.b=P+eEzIQk Received: by mail-ie0-f173.google.com with SMTP id lx4so9005465iec.32 for ; Tue, 27 May 2014 08:38:23 -0700 (PDT) X-Received: by 10.50.118.102 with SMTP id kl6mr19221958igb.7.1401205102938; Tue, 27 May 2014 08:38:22 -0700 (PDT) Received: from seurat.1015granger.net ([2604:8800:100:81fc:20c:29ff:fe44:ec31]) by mx.google.com with ESMTPSA id kw1sm8463850igb.20.2014.05.27.08.38.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 May 2014 08:38:22 -0700 (PDT) To: fedfs-utils-devel@oss.oracle.com From: Chuck Lever Date: Tue, 27 May 2014 11:38:21 -0400 Message-ID: <20140527153821.1177.99095.stgit@seurat.1015granger.net> In-Reply-To: <20140527153133.1177.54989.stgit@seurat.1015granger.net> References: <20140527153133.1177.54989.stgit@seurat.1015granger.net> User-Agent: StGit/0.16 MIME-Version: 1.0 X-Flow-Control-Info: class=Pass-to-MM reputation=ipRisk-All ip=209.85.223.173 ct-class=R5 ct-vol1=-83 ct-vol2=8 ct-vol3=7 ct-risk=42 ct-spam1=63 ct-spam2=7 ct-bulk=6 rcpts=1 size=7576 X-Sendmail-CM-Score: 0.00% X-Sendmail-CM-Analysis: v=2.1 cv=E4H0+8tl c=1 sm=1 tr=0 a=qwGkLdSk1mnbbqJ/Hkv+eg==:117 a=dzsqy3y4QnMA:10 a=pH8qlIIGtLYA:10 a=dPGociXpb70A:10 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=yPCof4ZbAAAA:8 a=Lb1rMZzfAAAA:8 a=1XWaLZrsAAAA:8 a=asXWUlJrNm51Bi-SkZ4A:9 a=QEXdDO 2ut3YA:10 a=7DSvI1NPTFQA:10 X-Sendmail-CT-RefID: str=0001.0A090202.5384B170.0058, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-Sendmail-CT-Classification: not spam Subject: [fedfs-utils] [PATCH 14/17] nsdbc: Fix missing break X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet22.oracle.com [141.146.126.238] Avoid using fallthrough logic in switch statements. Fixes: 0520ee7207f9ba027c845cb33606a3c901ecd811 Signed-off-by: Chuck Lever --- src/nsdbc/nsdb-annotate.c | 1 - src/nsdbc/nsdb-create-fsl.c | 3 ++- src/nsdbc/nsdb-create-fsn.c | 3 ++- src/nsdbc/nsdb-delete-fsl.c | 3 ++- src/nsdbc/nsdb-delete-fsn.c | 3 ++- src/nsdbc/nsdb-delete-nsdb.c | 3 ++- src/nsdbc/nsdb-describe.c | 3 ++- src/nsdbc/nsdb-list.c | 3 ++- src/nsdbc/nsdb-nces.c | 3 ++- src/nsdbc/nsdb-remove-nci.c | 3 ++- src/nsdbc/nsdb-resolve-fsn.c | 3 ++- src/nsdbc/nsdb-simple-nce.c | 3 ++- src/nsdbc/nsdb-update-fsl.c | 3 ++- src/nsdbc/nsdb-update-nci.c | 3 ++- 14 files changed, 26 insertions(+), 14 deletions(-) diff --git a/src/nsdbc/nsdb-annotate.c b/src/nsdbc/nsdb-annotate.c index d35c7a491ec2..19fc8eb4b1ee 100644 --- a/src/nsdbc/nsdb-annotate.c +++ b/src/nsdbc/nsdb-annotate.c @@ -167,7 +167,6 @@ main(int argc, char **argv) break; case '?': nsdb_annotate_usage(progname); - break; default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); diff --git a/src/nsdbc/nsdb-create-fsl.c b/src/nsdbc/nsdb-create-fsl.c index ef79cc731feb..0ffd2e6614d1 100644 --- a/src/nsdbc/nsdb-create-fsl.c +++ b/src/nsdbc/nsdb-create-fsl.c @@ -162,10 +162,11 @@ main(int argc, char **argv) nsdb_create_fsl_usage(progname); } break; + case '?': + nsdb_create_fsl_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_create_fsl_usage(progname); } } diff --git a/src/nsdbc/nsdb-create-fsn.c b/src/nsdbc/nsdb-create-fsn.c index d6c39ea94124..d4bcd6eb6f72 100644 --- a/src/nsdbc/nsdb-create-fsn.c +++ b/src/nsdbc/nsdb-create-fsn.c @@ -170,10 +170,11 @@ main(int argc, char **argv) } ttl = (unsigned int)tmp; break; + case '?': + nsdb_create_fsn_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_create_fsn_usage(progname); } } diff --git a/src/nsdbc/nsdb-delete-fsl.c b/src/nsdbc/nsdb-delete-fsl.c index f64a8fde5316..eb6b4026e451 100644 --- a/src/nsdbc/nsdb-delete-fsl.c +++ b/src/nsdbc/nsdb-delete-fsl.c @@ -152,10 +152,11 @@ main(int argc, char **argv) nsdb_delete_fsl_usage(progname); } break; + case '?': + nsdb_delete_fsl_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_delete_fsl_usage(progname); } } diff --git a/src/nsdbc/nsdb-delete-fsn.c b/src/nsdbc/nsdb-delete-fsn.c index 3060c247e2d8..d76bfad1c3d8 100644 --- a/src/nsdbc/nsdb-delete-fsn.c +++ b/src/nsdbc/nsdb-delete-fsn.c @@ -154,10 +154,11 @@ main(int argc, char **argv) case 'y': leave_fsn = true; break; + case '?': + nsdb_delete_fsn_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_delete_fsn_usage(progname); } } diff --git a/src/nsdbc/nsdb-delete-nsdb.c b/src/nsdbc/nsdb-delete-nsdb.c index 2e793bf00b96..e49c5d59446b 100644 --- a/src/nsdbc/nsdb-delete-nsdb.c +++ b/src/nsdbc/nsdb-delete-nsdb.c @@ -138,10 +138,11 @@ main(int argc, char **argv) nsdb_delete_nsdb_usage(progname); } break; + case '?': + nsdb_delete_nsdb_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_delete_nsdb_usage(progname); } } diff --git a/src/nsdbc/nsdb-describe.c b/src/nsdbc/nsdb-describe.c index ec060be5bf5b..59ce45d3ca92 100644 --- a/src/nsdbc/nsdb-describe.c +++ b/src/nsdbc/nsdb-describe.c @@ -154,10 +154,11 @@ main(int argc, char **argv) case 'y': delete = true; break; + case '?': + nsdb_describe_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_describe_usage(progname); } } diff --git a/src/nsdbc/nsdb-list.c b/src/nsdbc/nsdb-list.c index e6de357a539d..3f9288b35430 100644 --- a/src/nsdbc/nsdb-list.c +++ b/src/nsdbc/nsdb-list.c @@ -329,10 +329,11 @@ main(int argc, char **argv) nsdb_list_usage(progname); } break; + case '?': + nsdb_list_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_list_usage(progname); } } diff --git a/src/nsdbc/nsdb-nces.c b/src/nsdbc/nsdb-nces.c index c67fd18936b0..b4f74fc4e64c 100644 --- a/src/nsdbc/nsdb-nces.c +++ b/src/nsdbc/nsdb-nces.c @@ -135,10 +135,11 @@ main(int argc, char **argv) nsdb_nces_usage(progname); } break; + case '?': + nsdb_nces_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_nces_usage(progname); } } diff --git a/src/nsdbc/nsdb-remove-nci.c b/src/nsdbc/nsdb-remove-nci.c index f6b58c9d0ab8..abcad47c5c9b 100644 --- a/src/nsdbc/nsdb-remove-nci.c +++ b/src/nsdbc/nsdb-remove-nci.c @@ -143,10 +143,11 @@ main(int argc, char **argv) nsdb_remove_nci_usage(progname); } break; + case '?': + nsdb_remove_nci_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_remove_nci_usage(progname); } } diff --git a/src/nsdbc/nsdb-resolve-fsn.c b/src/nsdbc/nsdb-resolve-fsn.c index 1230e6d76aef..100f7aa97edd 100644 --- a/src/nsdbc/nsdb-resolve-fsn.c +++ b/src/nsdbc/nsdb-resolve-fsn.c @@ -293,10 +293,11 @@ main(int argc, char **argv) nsdb_resolve_fsn_usage(progname); } break; + case '?': + nsdb_resolve_fsn_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_resolve_fsn_usage(progname); } } diff --git a/src/nsdbc/nsdb-simple-nce.c b/src/nsdbc/nsdb-simple-nce.c index 75c0386fcc2e..c99952ce85fe 100644 --- a/src/nsdbc/nsdb-simple-nce.c +++ b/src/nsdbc/nsdb-simple-nce.c @@ -138,10 +138,11 @@ main(int argc, char **argv) nsdb_simple_nce_usage(progname); } break; + case '?': + nsdb_simple_nce_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_simple_nce_usage(progname); } } diff --git a/src/nsdbc/nsdb-update-fsl.c b/src/nsdbc/nsdb-update-fsl.c index f5a4cb9249fd..23330ca380a5 100644 --- a/src/nsdbc/nsdb-update-fsl.c +++ b/src/nsdbc/nsdb-update-fsl.c @@ -158,10 +158,11 @@ main(int argc, char **argv) case 'v': value = optarg; break; + case '?': + nsdb_update_fsl_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_update_fsl_usage(progname); } } diff --git a/src/nsdbc/nsdb-update-nci.c b/src/nsdbc/nsdb-update-nci.c index 2da0aa13cc69..fa10d847a09f 100644 --- a/src/nsdbc/nsdb-update-nci.c +++ b/src/nsdbc/nsdb-update-nci.c @@ -151,10 +151,11 @@ main(int argc, char **argv) case 'y': delete = true; break; + case '?': + nsdb_update_nci_usage(progname); default: fprintf(stderr, "Invalid command line " "argument: %c\n", (char)arg); - case '?': nsdb_update_nci_usage(progname); } }