diff mbox

[2/5] libadmin: Enable compilation warnings for libadmin

Message ID 20131122003948.54630.25622.stgit@seurat.1015granger.net
State Accepted
Headers show

Commit Message

Chuck Lever Nov. 22, 2013, 12:39 a.m. UTC 
I'm about to add human-written code in libadmin.  For that, I'd like
to enable the full set of compilation warnings.

Machine-generated code should be subject to the same scrutiny as
human-written code anyway, but code produced by rpcgen often has
extraneous bits that throw harmless compiler warnings.

For now, fix these up by hand.  We do have a version control
subsystem in place to track any modifications we make by hand, so
that they can be replicated if the ADMIN protocol is ever updated.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 src/libadmin/Makefile.am       |    5 ++--
 src/libadmin/fedfs_admin_xdr.c |   50 ----------------------------------------
 2 files changed, 3 insertions(+), 52 deletions(-)
diff mbox

Patch

diff --git a/src/libadmin/Makefile.am b/src/libadmin/Makefile.am
index 271549c..7351254 100644
--- a/src/libadmin/Makefile.am
+++ b/src/libadmin/Makefile.am
@@ -29,6 +29,7 @@  libadmin_la_SOURCES	= fedfs_admin_xdr.c
 CLEANFILES		= cscope.in.out cscope.out cscope.po.out *~
 DISTCLEANFILES		= Makefile.in
 
-# Squelch compiler warnings for rpcgen-produced source code
-AM_CFLAGS		= -ggdb -fstrict-aliasing
+AM_CFLAGS		= -ggdb -fstrict-aliasing \
+			  -Wall -Wextra -pedantic -Wformat=2 \
+			  -Wstrict-aliasing=2 -Wp,-D_FORTIFY_SOURCE=2
 AM_CPPFLAGS		= -I. -I$(top_srcdir)/src/include -I/usr/include/tirpc
diff --git a/src/libadmin/fedfs_admin_xdr.c b/src/libadmin/fedfs_admin_xdr.c
index dbebbe1..15cc22a 100644
--- a/src/libadmin/fedfs_admin_xdr.c
+++ b/src/libadmin/fedfs_admin_xdr.c
@@ -8,8 +8,6 @@ 
 bool_t
 xdr_FedFsStatus (XDR *xdrs, FedFsStatus *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_enum (xdrs, (enum_t *) objp))
 		 return FALSE;
 	return TRUE;
@@ -18,8 +16,6 @@  xdr_FedFsStatus (XDR *xdrs, FedFsStatus *objp)
 bool_t
 xdr_utf8string (XDR *xdrs, utf8string *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_bytes (xdrs, (char **)&objp->utf8string_val, (u_int *) &objp->utf8string_len, ~0))
 		 return FALSE;
 	return TRUE;
@@ -28,8 +24,6 @@  xdr_utf8string (XDR *xdrs, utf8string *objp)
 bool_t
 xdr_ascii_REQUIRED4 (XDR *xdrs, ascii_REQUIRED4 *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_utf8string (xdrs, objp))
 		 return FALSE;
 	return TRUE;
@@ -38,8 +32,6 @@  xdr_ascii_REQUIRED4 (XDR *xdrs, ascii_REQUIRED4 *objp)
 bool_t
 xdr_utf8val_REQUIRED4 (XDR *xdrs, utf8val_REQUIRED4 *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_utf8string (xdrs, objp))
 		 return FALSE;
 	return TRUE;
@@ -48,8 +40,6 @@  xdr_utf8val_REQUIRED4 (XDR *xdrs, utf8val_REQUIRED4 *objp)
 bool_t
 xdr_FedFsUuid (XDR *xdrs, FedFsUuid objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_opaque (xdrs, objp, 16))
 		 return FALSE;
 	return TRUE;
@@ -58,8 +48,6 @@  xdr_FedFsUuid (XDR *xdrs, FedFsUuid objp)
 bool_t
 xdr_FedFsNsdbName (XDR *xdrs, FedFsNsdbName *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_u_int (xdrs, &objp->port))
 		 return FALSE;
 	 if (!xdr_utf8val_REQUIRED4 (xdrs, &objp->hostname))
@@ -70,8 +58,6 @@  xdr_FedFsNsdbName (XDR *xdrs, FedFsNsdbName *objp)
 bool_t
 xdr_FedFsPathComponent (XDR *xdrs, FedFsPathComponent *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_ascii_REQUIRED4 (xdrs, objp))
 		 return FALSE;
 	return TRUE;
@@ -80,8 +66,6 @@  xdr_FedFsPathComponent (XDR *xdrs, FedFsPathComponent *objp)
 bool_t
 xdr_FedFsPathName (XDR *xdrs, FedFsPathName *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_array (xdrs, (char **)&objp->FedFsPathName_val, (u_int *) &objp->FedFsPathName_len, ~0,
 		sizeof (FedFsPathComponent), (xdrproc_t) xdr_FedFsPathComponent))
 		 return FALSE;
@@ -91,8 +75,6 @@  xdr_FedFsPathName (XDR *xdrs, FedFsPathName *objp)
 bool_t
 xdr_FedFsFsn (XDR *xdrs, FedFsFsn *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsUuid (xdrs, objp->fsnUuid))
 		 return FALSE;
 	 if (!xdr_FedFsNsdbName (xdrs, &objp->nsdbName))
@@ -103,8 +85,6 @@  xdr_FedFsFsn (XDR *xdrs, FedFsFsn *objp)
 bool_t
 xdr_FedFsFslType (XDR *xdrs, FedFsFslType *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_enum (xdrs, (enum_t *) objp))
 		 return FALSE;
 	return TRUE;
@@ -113,8 +93,6 @@  xdr_FedFsFslType (XDR *xdrs, FedFsFslType *objp)
 bool_t
 xdr_FedFsNfsFsl (XDR *xdrs, FedFsNfsFsl *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsUuid (xdrs, objp->fslUuid))
 		 return FALSE;
 	 if (!xdr_u_int (xdrs, &objp->port))
@@ -129,8 +107,6 @@  xdr_FedFsNfsFsl (XDR *xdrs, FedFsNfsFsl *objp)
 bool_t
 xdr_FedFsFsl (XDR *xdrs, FedFsFsl *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsFslType (xdrs, &objp->type))
 		 return FALSE;
 	switch (objp->type) {
@@ -147,8 +123,6 @@  xdr_FedFsFsl (XDR *xdrs, FedFsFsl *objp)
 bool_t
 xdr_FedFsPathType (XDR *xdrs, FedFsPathType *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_enum (xdrs, (enum_t *) objp))
 		 return FALSE;
 	return TRUE;
@@ -157,8 +131,6 @@  xdr_FedFsPathType (XDR *xdrs, FedFsPathType *objp)
 bool_t
 xdr_FedFsPath (XDR *xdrs, FedFsPath *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsPathType (xdrs, &objp->type))
 		 return FALSE;
 	switch (objp->type) {
@@ -179,8 +151,6 @@  xdr_FedFsPath (XDR *xdrs, FedFsPath *objp)
 bool_t
 xdr_FedFsCreateArgs (XDR *xdrs, FedFsCreateArgs *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsPath (xdrs, &objp->path))
 		 return FALSE;
 	 if (!xdr_FedFsFsn (xdrs, &objp->fsn))
@@ -191,8 +161,6 @@  xdr_FedFsCreateArgs (XDR *xdrs, FedFsCreateArgs *objp)
 bool_t
 xdr_FedFsResolveType (XDR *xdrs, FedFsResolveType *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_enum (xdrs, (enum_t *) objp))
 		 return FALSE;
 	return TRUE;
@@ -201,8 +169,6 @@  xdr_FedFsResolveType (XDR *xdrs, FedFsResolveType *objp)
 bool_t
 xdr_FedFsLookupArgs (XDR *xdrs, FedFsLookupArgs *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsPath (xdrs, &objp->path))
 		 return FALSE;
 	 if (!xdr_FedFsResolveType (xdrs, &objp->resolve))
@@ -213,8 +179,6 @@  xdr_FedFsLookupArgs (XDR *xdrs, FedFsLookupArgs *objp)
 bool_t
 xdr_FedFsLookupResOk (XDR *xdrs, FedFsLookupResOk *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsFsn (xdrs, &objp->fsn))
 		 return FALSE;
 	 if (!xdr_array (xdrs, (char **)&objp->fsl.fsl_val, (u_int *) &objp->fsl.fsl_len, ~0,
@@ -226,8 +190,6 @@  xdr_FedFsLookupResOk (XDR *xdrs, FedFsLookupResOk *objp)
 bool_t
 xdr_FedFsLookupResReferralVal (XDR *xdrs, FedFsLookupResReferralVal *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsNsdbName (xdrs, &objp->targetNsdb))
 		 return FALSE;
 	 if (!xdr_u_int (xdrs, &objp->ldapResultCode))
@@ -238,8 +200,6 @@  xdr_FedFsLookupResReferralVal (XDR *xdrs, FedFsLookupResReferralVal *objp)
 bool_t
 xdr_FedFsLookupRes (XDR *xdrs, FedFsLookupRes *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsStatus (xdrs, &objp->status))
 		 return FALSE;
 	switch (objp->status) {
@@ -270,8 +230,6 @@  xdr_FedFsLookupRes (XDR *xdrs, FedFsLookupRes *objp)
 bool_t
 xdr_FedFsConnectionSec (XDR *xdrs, FedFsConnectionSec *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_enum (xdrs, (enum_t *) objp))
 		 return FALSE;
 	return TRUE;
@@ -280,8 +238,6 @@  xdr_FedFsConnectionSec (XDR *xdrs, FedFsConnectionSec *objp)
 bool_t
 xdr_FedFsNsdbParams (XDR *xdrs, FedFsNsdbParams *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsConnectionSec (xdrs, &objp->secType))
 		 return FALSE;
 	switch (objp->secType) {
@@ -298,8 +254,6 @@  xdr_FedFsNsdbParams (XDR *xdrs, FedFsNsdbParams *objp)
 bool_t
 xdr_FedFsSetNsdbParamsArgs (XDR *xdrs, FedFsSetNsdbParamsArgs *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsNsdbName (xdrs, &objp->nsdbName))
 		 return FALSE;
 	 if (!xdr_FedFsNsdbParams (xdrs, &objp->params))
@@ -310,8 +264,6 @@  xdr_FedFsSetNsdbParamsArgs (XDR *xdrs, FedFsSetNsdbParamsArgs *objp)
 bool_t
 xdr_FedFsGetNsdbParamsRes (XDR *xdrs, FedFsGetNsdbParamsRes *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsStatus (xdrs, &objp->status))
 		 return FALSE;
 	switch (objp->status) {
@@ -328,8 +280,6 @@  xdr_FedFsGetNsdbParamsRes (XDR *xdrs, FedFsGetNsdbParamsRes *objp)
 bool_t
 xdr_FedFsGetLimitedNsdbParamsRes (XDR *xdrs, FedFsGetLimitedNsdbParamsRes *objp)
 {
-	register int32_t *buf;
-
 	 if (!xdr_FedFsStatus (xdrs, &objp->status))
 		 return FALSE;
 	switch (objp->status) {