diff mbox

[2/8] libnsdb: Fix nsdb_ping_contexts_s()

Message ID 20131113215350.23593.49769.stgit@seurat.1015granger.net
State Accepted
Headers show

Commit Message

Chuck Lever Nov. 13, 2013, 9:53 p.m. UTC 
Commit a9c62419 added a switch() in a for() loop, which changes
the semantics of "break;".

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 src/libnsdb/fileserver.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c
index d3f7560..9c80521 100644
--- a/src/libnsdb/fileserver.c
+++ b/src/libnsdb/fileserver.c
@@ -1757,17 +1757,18 @@  nsdb_ping_contexts_s(nsdb_t host, char **contexts, unsigned int *ldap_err)
 		switch (retval) {
 		case FEDFS_OK:
 			free(dn);
-			break;
+			goto out;
 		case FEDFS_ERR_NSDB_LDAP_VAL:
 			if (ldap_result == LDAP_CONFIDENTIALITY_REQUIRED)
 				retval = FEDFS_ERR_NSDB_AUTH;
 			else
 				*ldap_err = ldap_result;
-			break;
+			goto out;
 		default:
 			retval = FEDFS_ERR_NSDB_NONCE;
 		}
 	}
+out:
 	return retval;
 }