diff mbox series

[RFC,2/5] dt-bindings: pci: controller: add pcie controller binding for RK3588

Message ID fe221481f4df1b552183648489a02ab5ac3216e6.1675498628.git.wqu@suse.com
State Not Applicable, archived
Headers show
Series arm64: rockchip: enable PCIE3 controller and its phy for Rock5B boards | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Qu Wenruo Feb. 4, 2023, 8:47 a.m. UTC
All the properties are the same with RK3568 PCIE controllers, and in
fact the driver can also be reused between RK3568 and RK3588
PCIE controllers.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Feb. 6, 2023, 10:43 a.m. UTC | #1
On 04/02/2023 09:47, Qu Wenruo wrote:
> All the properties are the same with RK3568 PCIE controllers, and in

Subject: drop second/last, redundant "binding". The "dt-bindings" prefix
is already stating that these are bindings.


> fact the driver can also be reused between RK3568 and RK3588
> PCIE controllers.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
index 2be72ae1169f..473c90a163b1 100644
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
@@ -21,8 +21,9 @@  allOf:
 
 properties:
   compatible:
-    items:
-      - const: rockchip,rk3568-pcie
+    enum:
+      - rockchip,rk3568-pcie
+      - rockchip,rk3588-pcie
 
   reg:
     items: