diff mbox series

dt-bindings: leds: common: Add missing triggers

Message ID f24b081ad7f4695c039cfb9256aae8a522797fcf.1598265564.git.michal.simek@xilinx.com
State Changes Requested
Headers show
Series dt-bindings: leds: common: Add missing triggers | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Michal Simek Aug. 24, 2020, 10:39 a.m. UTC
Xilinx ZynqMP zcu100/ultra96 v1 defines additional triggers which are not
covered by common.yaml. The patch adds missing triggers for this platform.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

There are a lot of other triggers which are missing but the patch focus on
fixing my platform
---
 Documentation/devicetree/bindings/leds/common.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring Sept. 8, 2020, 10:23 p.m. UTC | #1
On Mon, Aug 24, 2020 at 12:39:27PM +0200, Michal Simek wrote:
> Xilinx ZynqMP zcu100/ultra96 v1 defines additional triggers which are not
> covered by common.yaml. The patch adds missing triggers for this platform.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> There are a lot of other triggers which are missing but the patch focus on
> fixing my platform

The idea was to standardize these and not add a bunch of similar ones. 
Also, there's the 'function' property which is preferred as well as the 
trigger source binding now to better associate LEDs with specific h/w.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index a2a541bca73c..c3d728a06782 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -82,6 +82,8 @@  properties:
     enum:
         # LED will act as a back-light, controlled by the framebuffer system
       - backlight
+        # LED indicates enabling power for bluetooth device
+      - bluetooth-power
         # LED will turn on (but for leds-gpio see "default-state" property in
         # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
       - default-on
@@ -97,6 +99,9 @@  properties:
         # LED alters the brightness for the specified duration with one software
         # timer (requires "led-pattern" property)
       - pattern
+        # LED flashes based on networking activity on tx and rx channels
+      - phy0tx
+      - phy0rx
 
   led-pattern:
     description: |