diff mbox series

dt-bindings: mmc: Add missing description for clk_in/out_sd1

Message ID aef586778921c93377ec2f31c86e151b6e93f6c7.1598257520.git.michal.simek@xilinx.com
State Not Applicable
Headers show
Series dt-bindings: mmc: Add missing description for clk_in/out_sd1 | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch warning total: 0 errors, 2 warnings, 16 lines checked

Commit Message

Michal Simek Aug. 24, 2020, 8:25 a.m. UTC
The commit a8fdb80f4d47 ("arm64: zynqmp: Add ZynqMP SDHCI compatible
string") added clock-output-names for both SDHCIs before DT binding yaml
conversion. But only clk_in/out_sd0 clock names have been covered by
DT binding which ends up with dt yaml checking warnings as:
From schema: .../Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
... mmc@ff170000: clock-output-names:0: 'clk_out_sd0' was expected
... mmc@ff170000: clock-output-names:1: 'clk_in_sd0' was expected

Fixes: 16ecd8f33c6e ("dt-bindings: mmc: convert arasan sdhci bindings to yaml")
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 .../devicetree/bindings/mmc/arasan,sdhci.yaml          | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Manish Narani Aug. 25, 2020, 4:58 a.m. UTC | #1
> -----Original Message-----
> From: Michal Simek <monstr@monstr.eu> On Behalf Of Michal Simek
> Sent: Monday, August 24, 2020 1:55 PM
> To: linux-kernel@vger.kernel.org; monstr@monstr.eu; Michal Simek
> <michals@xilinx.com>; git <git@xilinx.com>; Manish Narani
> <MNARANI@xilinx.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>; Rob Herring
> <robh+dt@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; Wan Ahmad
> Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>;
> devicetree@vger.kernel.org; linux-mmc@vger.kernel.org
> Subject: [PATCH] dt-bindings: mmc: Add missing description for clk_in/out_sd1
> 
> The commit a8fdb80f4d47 ("arm64: zynqmp: Add ZynqMP SDHCI compatible
> string") added clock-output-names for both SDHCIs before DT binding yaml
> conversion. But only clk_in/out_sd0 clock names have been covered by
> DT binding which ends up with dt yaml checking warnings as:
> From schema: .../Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> ... mmc@ff170000: clock-output-names:0: 'clk_out_sd0' was expected
> ... mmc@ff170000: clock-output-names:1: 'clk_in_sd0' was expected
> 
> Fixes: 16ecd8f33c6e ("dt-bindings: mmc: convert arasan sdhci bindings to yaml")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Manish Narani <manish.narani@xilinx.com>
Ulf Hansson Aug. 25, 2020, 9:38 a.m. UTC | #2
On Mon, 24 Aug 2020 at 10:25, Michal Simek <michal.simek@xilinx.com> wrote:
>
> The commit a8fdb80f4d47 ("arm64: zynqmp: Add ZynqMP SDHCI compatible
> string") added clock-output-names for both SDHCIs before DT binding yaml
> conversion. But only clk_in/out_sd0 clock names have been covered by
> DT binding which ends up with dt yaml checking warnings as:
> From schema: .../Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> ... mmc@ff170000: clock-output-names:0: 'clk_out_sd0' was expected
> ... mmc@ff170000: clock-output-names:1: 'clk_in_sd0' was expected
>
> Fixes: 16ecd8f33c6e ("dt-bindings: mmc: convert arasan sdhci bindings to yaml")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
>
>  .../devicetree/bindings/mmc/arasan,sdhci.yaml          | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 5887c917d480..58fe9d02a781 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -30,9 +30,13 @@ allOf:
>      then:
>        properties:
>          clock-output-names:
> -          items:
> -            - const: clk_out_sd0
> -            - const: clk_in_sd0
> +          oneOf:
> +            - items:
> +              - const: clk_out_sd0
> +              - const: clk_in_sd0
> +            - items:
> +              - const: clk_out_sd1
> +              - const: clk_in_sd1
>
>  properties:
>    compatible:
> --
> 2.28.0
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
index 5887c917d480..58fe9d02a781 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
@@ -30,9 +30,13 @@  allOf:
     then:
       properties:
         clock-output-names:
-          items:
-            - const: clk_out_sd0
-            - const: clk_in_sd0
+          oneOf:
+            - items:
+              - const: clk_out_sd0
+              - const: clk_in_sd0
+            - items:
+              - const: clk_out_sd1
+              - const: clk_in_sd1
 
 properties:
   compatible: