diff mbox series

[net,2/4] net:phy:smsc: expand documentation of clocks property

Message ID CY4PR1701MB187834A07970380742371D78DF160@CY4PR1701MB1878.namprd17.prod.outlook.com
State Not Applicable
Headers show
Series Restore and fix PHY reset for SMSC LAN8720 | expand

Checks

Context Check Description
robh/checkpatch warning total: 1 errors, 1 warnings, 9 lines checked

Commit Message

Badel, Laurent Oct. 27, 2020, 11:27 p.m. UTC
Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property

Description: The ref clock is managed differently when added to the DT
entry for SMSC PHY. Thus, specify this more clearly in the documentation.

Signed-off-by: Laurent Badel <laurentbadel@eaton.com>
---
 Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rob Herring Oct. 30, 2020, 7:19 p.m. UTC | #1
On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote:
> Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property
> 
> Description: The ref clock is managed differently when added to the DT
> entry for SMSC PHY. Thus, specify this more clearly in the documentation.
> 
> Signed-off-by: Laurent Badel <laurentbadel@eaton.com>
> ---
>  Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Badel, Laurent Nov. 4, 2020, 12:11 p.m. UTC | #2
> 

-----------------------------
Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland 

-----------------------------

-----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, October 30, 2020 8:19 PM
> To: Badel, Laurent <LaurentBadel@eaton.com>
> Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch;
> lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org;
> kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com;
> netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>;
> p.zabel@pengutronix.de; devicetree@vger.kernel.org; f.fainelli@gmail.com;
> broonie@kernel.org; Heiner Kallweit <hkallweit1@gmail.com>
> Subject: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand
> documentation of clocks property
> 
> On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote:
> > Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks
> > property
> >
> > Description: The ref clock is managed differently when added to the DT
> > entry for SMSC PHY. Thus, specify this more clearly in the documentation.
> >
> > Signed-off-by: Laurent Badel <laurentbadel@eaton.com>
> > ---
> >  Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thank you very much.
I'm guessing perhaps I should re-send this as a single patch since there 
are issues with the patch series?
I realize now that I should have splitted things differently.
Florian Fainelli Nov. 4, 2020, 4:01 p.m. UTC | #3
On 11/4/2020 4:11 AM, Badel, Laurent wrote:
> > 
> 
> -----------------------------
> Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland 
> 
> -----------------------------
> 
> -----Original Message-----
>> From: Rob Herring <robh@kernel.org>
>> Sent: Friday, October 30, 2020 8:19 PM
>> To: Badel, Laurent <LaurentBadel@eaton.com>
>> Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch;
>> lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org;
>> kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com;
>> netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>;
>> p.zabel@pengutronix.de; devicetree@vger.kernel.org; f.fainelli@gmail.com;
>> broonie@kernel.org; Heiner Kallweit <hkallweit1@gmail.com>
>> Subject: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand
>> documentation of clocks property
>>
>> On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote:
>>> Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks
>>> property
>>>
>>> Description: The ref clock is managed differently when added to the DT
>>> entry for SMSC PHY. Thus, specify this more clearly in the documentation.
>>>
>>> Signed-off-by: Laurent Badel <laurentbadel@eaton.com>
>>> ---
>>>  Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>
>> Acked-by: Rob Herring <robh@kernel.org>
> 
> Thank you very much.
> I'm guessing perhaps I should re-send this as a single patch since there 
> are issues with the patch series?
> I realize now that I should have splitted things differently.

There are several things with your patch series that make it very hard
to be followed or to even know what is the latest version of your patch
series. If you can resubmit everything targeting the 'net' tree along
with a cover letter explaining the differences between v1 and v2 that
would help. Please make sure that all of your patches reference the
cover letter's Message-Id which is the default if you use git
format-patch --cover-letter .

Thanks
Badel, Laurent Nov. 9, 2020, 3:16 p.m. UTC | #4


> 

-----------------------------
Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland 

-----------------------------

-----Original Message-----
> From: Florian Fainelli <f.fainelli@gmail.com>
> Sent: Wednesday, November 04, 2020 5:02 PM
> To: Badel, Laurent <LaurentBadel@eaton.com>; Rob Herring
> <robh@kernel.org>
> Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch;
> lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org;
> kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com;
> netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>;
> p.zabel@pengutronix.de; devicetree@vger.kernel.org; broonie@kernel.org;
> Heiner Kallweit <hkallweit1@gmail.com>
> Subject: Re: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand
> documentation of clocks property
> 
> 
> 
> On 11/4/2020 4:11 AM, Badel, Laurent wrote:
> > >
> >
> > -----------------------------
> > Eaton Industries Manufacturing GmbH ~ Registered place of business:
> > Route de la Longeraie 7, 1110, Morges, Switzerland
> >
> > -----------------------------
> >
> > -----Original Message-----
> >> From: Rob Herring <robh@kernel.org>
> >> Sent: Friday, October 30, 2020 8:19 PM
> >> To: Badel, Laurent <LaurentBadel@eaton.com>
> >> Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch;
> >> lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org;
> >> kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com;
> >> netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>;
> >> p.zabel@pengutronix.de; devicetree@vger.kernel.org;
> >> f.fainelli@gmail.com; broonie@kernel.org; Heiner Kallweit
> >> <hkallweit1@gmail.com>
> >> Subject: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand
> >> documentation of clocks property
> >>
> >> On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote:
> >>> Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of
> >>> clocks property
> >>>
> >>> Description: The ref clock is managed differently when added to the
> >>> DT entry for SMSC PHY. Thus, specify this more clearly in the
> documentation.
> >>>
> >>> Signed-off-by: Laurent Badel <laurentbadel@eaton.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++-
> >>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>
> >> Acked-by: Rob Herring <robh@kernel.org>
> >
> > Thank you very much.
> > I'm guessing perhaps I should re-send this as a single patch since
> > there are issues with the patch series?
> > I realize now that I should have splitted things differently.
> 
> There are several things with your patch series that make it very hard to be
> followed or to even know what is the latest version of your patch series. If
> you can resubmit everything targeting the 'net' tree along with a cover letter
> explaining the differences between v1 and v2 that would help. Please make
> sure that all of your patches reference the cover letter's Message-Id which is
> the default if you use git format-patch --cover-letter .
> 
> Thanks
> --
> Florian

I will make sure to give details as you suggested, sorry for the trouble and thank
you for your time reviewing. 
Laurent
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/smsc-lan87xx.txt b/Documentation/devicetree/bindings/net/smsc-lan87xx.txt
index a8d0dc9a8c0e..43f4763f0d3d 100644
--- a/Documentation/devicetree/bindings/net/smsc-lan87xx.txt
+++ b/Documentation/devicetree/bindings/net/smsc-lan87xx.txt
@@ -7,7 +7,8 @@  Optional properties:
 
 - clocks:
   The clock used as phy reference clock and is connected to phy
-  pin XTAL1/CLKIN.
+  pin XTAL1/CLKIN. If set, the clock will be managed by the PHY
+  driver and remain enabled for the lifetime of the driver.
 
 - smsc,disable-energy-detect:
   If set, do not enable energy detect mode for the SMSC phy.