| Message ID | AM0PR09MB267553535F7A85EA639D739C95082@AM0PR09MB2675.eurprd09.prod.outlook.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | trf7970a: Device tree option for RX gain reduction | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17/04/2024 00:18, Paul Geurts wrote: > Add option to reduce the RX antenna gain to be able to reduce the > sensitivity. > > Signed-off-by: Paul Geurts <paul_geurts@live.nl> > --- > Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml > index d0332eb76ad2..bbd045f6cf04 100644 > --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml > +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml > @@ -55,6 +55,11 @@ properties: > description: | > Regulator for supply voltage to VIN pin > > + rx-gain-reduction: Missing vendor prefix. > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | Do not need '|' unless you need to preserve formatting. > + Specify a RX gain reduction to reduce antenna sensitivity. Reduction by what? What are the units? Best regards, Krzysztof
On 17-04-2024 15:12, Krzysztof Kozlowski wrote: > On 17/04/2024 00:18, Paul Geurts wrote: >> Add option to reduce the RX antenna gain to be able to reduce the >> sensitivity. >> >> Signed-off-by: Paul Geurts <paul_geurts@live.nl> >> --- >> Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml >> index d0332eb76ad2..bbd045f6cf04 100644 >> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml >> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml >> @@ -55,6 +55,11 @@ properties: >> description: | >> Regulator for supply voltage to VIN pin >> >> + rx-gain-reduction: > Missing vendor prefix. > >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: | > Do not need '|' unless you need to preserve formatting. > >> + Specify a RX gain reduction to reduce antenna sensitivity. > Reduction by what? What are the units? Yes, this is a bit unclear indeed. Will clarify this. > > > Best regards, > Krzysztof Thanks! br, Paul
diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml index d0332eb76ad2..bbd045f6cf04 100644 --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml @@ -55,6 +55,11 @@ properties: description: | Regulator for supply voltage to VIN pin + rx-gain-reduction: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Specify a RX gain reduction to reduce antenna sensitivity. + required: - compatible - interrupts @@ -95,5 +100,6 @@ examples: irq-status-read-quirk; en2-rf-quirk; clock-frequency = <27120000>; + rx-gain-reduction = <3>; }; };
Add option to reduce the RX antenna gain to be able to reduce the sensitivity. Signed-off-by: Paul Geurts <paul_geurts@live.nl> --- Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++ 1 file changed, 6 insertions(+)