Message ID | 9bc2631ff3ab60fc607a5215e561aace83c0e8ca.1583464821.git.baolin.wang7@gmail.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | [1/2] dt-bindings: mailbox: Add the Spreadtrum mailbox documentation | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/dt-meta-schema | success |
On Fri, Mar 06, 2020 at 02:07:21PM +0800, Baolin Wang wrote: > From: Baolin Wang <baolin.wang@unisoc.com> > > Add the Spreadtrum mailbox documentation. > > Signed-off-by: Baolin Wang <baolin.wang@unisoc.com> > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com> > --- > .../devicetree/bindings/mailbox/sprd-mailbox.yaml | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > new file mode 100644 > index 0000000..2f2fdcf > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Spreadtrum mailbox controller bindings > + > +maintainers: > + - Orson Zhai <orsonzhai@gmail.com> > + - Baolin Wang <baolin.wang7@gmail.com> > + - Chunyan Zhang <zhang.lyra@gmail.com> > + > +properties: > + compatible: > + enum: > + - sprd,sc9860-mailbox > + > + reg: > + minItems: 2 Need to define what each entry is. > + > + interrupts: > + minItems: 2 > + description: > + Contains the inbox and outbox interrupt information. The description should be split to define each entry: items: - description: inbox interrupt - description: outbox interrupt > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: enable > + > + "#mbox-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#mbox-cells" > + - clocks > + - clock-names Add: additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + mailbox: mailbox@400a0000 { > + compatible = "sprd,sc9860-mailbox"; > + reg = <0 0x400a0000 0 0x8000>, <0 0x400a8000 0 0x8000>; > + #mbox-cells = <1>; > + clock-names = "enable"; > + clocks = <&aon_gate 53>; > + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>; > + }; > +... > -- > 1.9.1 >
Hi Rob, On Fri, Mar 13, 2020 at 3:16 AM Rob Herring <robh@kernel.org> wrote: > > On Fri, Mar 06, 2020 at 02:07:21PM +0800, Baolin Wang wrote: > > From: Baolin Wang <baolin.wang@unisoc.com> > > > > Add the Spreadtrum mailbox documentation. > > > > Signed-off-by: Baolin Wang <baolin.wang@unisoc.com> > > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com> > > --- > > .../devicetree/bindings/mailbox/sprd-mailbox.yaml | 56 ++++++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > > > diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > new file mode 100644 > > index 0000000..2f2fdcf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > @@ -0,0 +1,56 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Spreadtrum mailbox controller bindings > > + > > +maintainers: > > + - Orson Zhai <orsonzhai@gmail.com> > > + - Baolin Wang <baolin.wang7@gmail.com> > > + - Chunyan Zhang <zhang.lyra@gmail.com> > > + > > +properties: > > + compatible: > > + enum: > > + - sprd,sc9860-mailbox > > + > > + reg: > > + minItems: 2 > > Need to define what each entry is. Sure > > > + > > + interrupts: > > + minItems: 2 > > + description: > > + Contains the inbox and outbox interrupt information. > > The description should be split to define each entry: > > items: > - description: inbox interrupt > - description: outbox interrupt Sure. > > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: enable > > + > > + "#mbox-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - "#mbox-cells" > > + - clocks > > + - clock-names > > Add: > > additionalProperties: false OK. Thanks for your comments.
diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml new file mode 100644 index 0000000..2f2fdcf --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Spreadtrum mailbox controller bindings + +maintainers: + - Orson Zhai <orsonzhai@gmail.com> + - Baolin Wang <baolin.wang7@gmail.com> + - Chunyan Zhang <zhang.lyra@gmail.com> + +properties: + compatible: + enum: + - sprd,sc9860-mailbox + + reg: + minItems: 2 + + interrupts: + minItems: 2 + description: + Contains the inbox and outbox interrupt information. + + clocks: + maxItems: 1 + + clock-names: + items: + - const: enable + + "#mbox-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - "#mbox-cells" + - clocks + - clock-names + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + mailbox: mailbox@400a0000 { + compatible = "sprd,sc9860-mailbox"; + reg = <0 0x400a0000 0 0x8000>, <0 0x400a8000 0 0x8000>; + #mbox-cells = <1>; + clock-names = "enable"; + clocks = <&aon_gate 53>; + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>; + }; +...