| Message ID | 5da43657817066e0ffe1e24cfb17104138515452.1613541226.git.schowdhu@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add driver support for Data Capture and Compare Engine(DCC) for SM8150 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On 17-02-21, 12:18, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. > > Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org> > --- > .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49 ++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > new file mode 100644 > index 0000000..8f09578 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Data Capture and Compare > + > +maintainers: > + - Souradeep Chowdhury <schowdhu@codeaurora.org> > + > +description: | > + DCC (Data Capture and Compare) is a DMA engine which is used to save > + configuration data or system memory contents during catastrophic failure > + or SW trigger.DCC is used to capture and store data for debugging purpose space after . > + > + > +properties: > + compatible: > + items: > + - enum: > + - qcom,sm8150-dcc > + - const: qcom,dcc > + > + reg: > + items: > + - description: DCC base register region > + - description: DCC RAM base register region > + > + reg-names: > + items: > + - const: dcc-base > + - const: dcc-ram-base drop dcc from names > + > +required: > + - compatible > + - reg > + - reg-names > + > +additionalProperties: false > + > +examples: > + - | > + dcc@010a2000{ > + compatible = "qcom,sm8150-dcc"; should this not be: compatible = "qcom,sm8150-dcc", "qcom,dcc"; > + reg = <0 0x010a2000 0 0x1000>, > + <0 0x010ae000 0 0x2000>; > + reg-names = "dcc-base", "dcc-ram-base"; > + }; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation
On 2021-02-17 16:32, Vinod Koul wrote: > On 17-02-21, 12:18, Souradeep Chowdhury wrote: >> Documentation for Data Capture and Compare(DCC) device tree bindings >> in yaml format. >> >> Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org> >> --- >> .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49 >> ++++++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml >> b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml >> new file mode 100644 >> index 0000000..8f09578 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml >> @@ -0,0 +1,49 @@ >> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Data Capture and Compare >> + >> +maintainers: >> + - Souradeep Chowdhury <schowdhu@codeaurora.org> >> + >> +description: | >> + DCC (Data Capture and Compare) is a DMA engine which is used to >> save >> + configuration data or system memory contents during catastrophic >> failure >> + or SW trigger.DCC is used to capture and store data for debugging >> purpose > > space after . Ack > >> + >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - qcom,sm8150-dcc >> + - const: qcom,dcc >> + >> + reg: >> + items: >> + - description: DCC base register region >> + - description: DCC RAM base register region >> + >> + reg-names: >> + items: >> + - const: dcc-base >> + - const: dcc-ram-base > > drop dcc from names Since DCC has a dedicated SRAM, this has been named like this as only base and ram-base are generic names. Let me know if this is still required to be changed. > >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + dcc@010a2000{ >> + compatible = "qcom,sm8150-dcc"; > > should this not be: > compatible = "qcom,sm8150-dcc", "qcom,dcc"; Ack > >> + reg = <0 0x010a2000 0 0x1000>, >> + <0 0x010ae000 0 0x2000>; >> + reg-names = "dcc-base", "dcc-ram-base"; >> + }; >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a >> member >> of Code Aurora Forum, hosted by The Linux Foundation
On Wed, 17 Feb 2021 12:18:22 +0530, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. > > Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org> > --- > .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49 ++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml:21:5: [warning] wrong indentation: expected 6 but found 4 (indentation) ./Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml:22:7: [warning] wrong indentation: expected 8 but found 6 (indentation) dtschema/dtc warnings/errors: Documentation/devicetree/bindings/arm/msm/qcom,dcc.example.dts:19.21-24.11: Warning (unit_address_format): /example-0/dcc@010a2000: unit name should not have leading 0s /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/msm/qcom,dcc.example.dt.yaml: example-0: dcc@010a2000:reg:0: [0, 17440768, 0, 4096] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/msm/qcom,dcc.example.dt.yaml: example-0: dcc@010a2000:reg:1: [0, 17489920, 0, 8192] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/msm/qcom,dcc.example.dt.yaml: dcc@010a2000: compatible: ['qcom,sm8150-dcc'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml See https://patchwork.ozlabs.org/patch/1441182 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml new file mode 100644 index 0000000..8f09578 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Data Capture and Compare + +maintainers: + - Souradeep Chowdhury <schowdhu@codeaurora.org> + +description: | + DCC (Data Capture and Compare) is a DMA engine which is used to save + configuration data or system memory contents during catastrophic failure + or SW trigger.DCC is used to capture and store data for debugging purpose + + +properties: + compatible: + items: + - enum: + - qcom,sm8150-dcc + - const: qcom,dcc + + reg: + items: + - description: DCC base register region + - description: DCC RAM base register region + + reg-names: + items: + - const: dcc-base + - const: dcc-ram-base + +required: + - compatible + - reg + - reg-names + +additionalProperties: false + +examples: + - | + dcc@010a2000{ + compatible = "qcom,sm8150-dcc"; + reg = <0 0x010a2000 0 0x1000>, + <0 0x010ae000 0 0x2000>; + reg-names = "dcc-base", "dcc-ram-base"; + };
Documentation for Data Capture and Compare(DCC) device tree bindings in yaml format. Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org> --- .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml