diff mbox series

[v1,2/6] dt-bindings: arm: sunxi: Add BigTreeTech CB1

Message ID 54C66F97A81FBC29+20230802220309.163804-3-martin@biqu3d.com
State Changes Requested, archived
Headers show
Series Add BigTreeTech CB1 SoM & Boards | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Martin Botka Aug. 2, 2023, 10:02 p.m. UTC 
From: Martin Botka <martin.botka@somainline.org>

Add a name & compatible for BigTreeTech CB1 SoM

Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Andre Przywara Aug. 3, 2023, 12:34 p.m. UTC | #1 
On Thu,  3 Aug 2023 00:02:35 +0200
Martin Botka <martin@biqu3d.com> wrote:

Hi,

> From: Martin Botka <martin.botka@somainline.org>
> 
> Add a name & compatible for BigTreeTech CB1 SoM
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index ee8fdd2da869..5ae1b81af6fc 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -151,6 +151,11 @@ properties:
>            - const: roofull,beelink-x2
>            - const: allwinner,sun8i-h3
>  
> +      - description: BigTreeTech CB1 SoM
> +        items:
> +          - const: bigtreetech,cb1
> +          - const: allwinner,sun50i-h616
> +

If I get this correctly, the CB1 is the SoM, which cannot be used on its
own, right? In this case there is no need for an entry in this file, since
this combination will never appear in a board .dts file alone.
So just drop this patch then.

Cheers,
Andre

>        - description: Chuwi V7 CW0825
>          items:
>            - const: chuwi,v7-cw0825
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index ee8fdd2da869..5ae1b81af6fc 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -151,6 +151,11 @@  properties:
           - const: roofull,beelink-x2
           - const: allwinner,sun8i-h3
 
+      - description: BigTreeTech CB1 SoM
+        items:
+          - const: bigtreetech,cb1
+          - const: allwinner,sun50i-h616
+
       - description: Chuwi V7 CW0825
         items:
           - const: chuwi,v7-cw0825