| Message ID | 20241030211847.413-1-bavishimithil@gmail.com |
|---|---|
| State | Needs Review / ACK |
| Headers | show |
| Series | Initial support for Samsung Galaxy Tab 2 series | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Oct 30, 2024 at 09:18:43PM +0000, Mithil Bavishi wrote: > Add samsung-espresso7 codename for the 7 inch variant > > Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> > --- > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + > 1 file changed, 1 insertion(+) > This is v2, so where is the changelog? Same for all other patches. No cover letter, no changelogs in patches. Best regards, Krzysztof
On Wed, Oct 30, 2024 at 09:18:44PM +0000, Mithil Bavishi wrote: > Create a device tree for the 3 inch variants (P3100, P3110, P3113) 3 inch variants of what? Describe here the hardware. > > Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> > --- Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > arch/arm/boot/dts/ti/omap/Makefile | 1 + > .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
Am Thu, 31 Oct 2024 09:18:49 +0100 schrieb Krzysztof Kozlowski <krzk@kernel.org>: > On Wed, Oct 30, 2024 at 09:18:43PM +0000, Mithil Bavishi wrote: > > Add samsung-espresso7 codename for the 7 inch variant > > > > Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> > > --- > > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > This is v2, so where is the changelog? Same for all other patches. No > cover letter, no changelogs in patches. > The cover letter including changelog is here: https://lore.kernel.org/linux-omap/20241030211215.347710-1-bavishimithil@gmail.com/T/#t seems like it was ripped apart somehow. Regards, Andreas
On 31/10/2024 09:24, Andreas Kemnade wrote: > Am Thu, 31 Oct 2024 09:18:49 +0100 > schrieb Krzysztof Kozlowski <krzk@kernel.org>: > >> On Wed, Oct 30, 2024 at 09:18:43PM +0000, Mithil Bavishi wrote: >>> Add samsung-espresso7 codename for the 7 inch variant >>> >>> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> >>> --- >>> Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >> >> This is v2, so where is the changelog? Same for all other patches. No >> cover letter, no changelogs in patches. >> > The cover letter including changelog is here: > https://lore.kernel.org/linux-omap/20241030211215.347710-1-bavishimithil@gmail.com/T/#t > > seems like it was ripped apart somehow. It's not attached to this thread. I don't have it in my mailbox. Neither did b4 when applying entire thread for review. Sending something separately or making it not accessible for review means it does not exist. Best regards, Krzysztof
> It's not attached to this thread. I don't have it in my mailbox. Neither > did b4 when applying entire thread for review. Sending something > separately or making it not accessible for review means it does not > exist. I am not sure why was sent seperately, I'm trying to learn this workflow so it may have been a ametuer mistake from my side, apologies for that. I have notes the changes you requested and will try to apply them in v3 along with others mentioned. Thanks a lot for your patience. Best Regards, Mithil
diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml index 93e04a109..3d09ec1ad 100644 --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -136,6 +136,7 @@ properties: - motorola,droid-bionic # Motorola Droid Bionic XT875 - motorola,xyboard-mz609 - motorola,xyboard-mz617 + - samsung,espresso7 - ti,omap4-panda - ti,omap4-sdp - const: ti,omap4430
Add samsung-espresso7 codename for the 7 inch variant Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+)