| Message ID | 20240609125901.76274-2-laurentiumihalcea111@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for imx8ulp's SIM | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 09/06/2024 14:58, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > > Add schema for imx8ulp's SIM reset controller. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > --- > .../bindings/reset/nxp,imx8ulp-sim-reset.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > new file mode 100644 > index 000000000000..e7faec55ff36 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml Use compatible as filename. > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/nxp,imx8ulp-sim-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8ULP System Integration Module Reset Controller > + > +maintainers: > + - Liu Ying <victor.liu@nxp.com> > + > +description: | Do not need '|' unless you need to preserve formatting. > + Some instances of i.MX8ULP's SIM may offer control > + over the reset of some components of a certain domain > + (e.g: AVD-SIM). > + > +properties: > + compatible: > + items: > + - enum: > + - nxp,imx8ulp-avd-sim-reset > + - const: syscon > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + '#reset-cells': > + const: 1 > + > + mux-controller: > + $ref: ../mux/reg-mux.yaml Full path, so /schemas/mux/reg-mux.yaml# > + > +required: > + - compatible > + - reg > + - '#reset-cells' > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: nxp,imx8ulp-avd-sim-reset > + then: > + required: > + - mux-controller > + - clocks This does not make much sense. You do not have other variants. > + > +additionalProperties: false Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml new file mode 100644 index 000000000000..e7faec55ff36 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/reset/nxp,imx8ulp-sim-reset.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX8ULP System Integration Module Reset Controller + +maintainers: + - Liu Ying <victor.liu@nxp.com> + +description: | + Some instances of i.MX8ULP's SIM may offer control + over the reset of some components of a certain domain + (e.g: AVD-SIM). + +properties: + compatible: + items: + - enum: + - nxp,imx8ulp-avd-sim-reset + - const: syscon + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + '#reset-cells': + const: 1 + + mux-controller: + $ref: ../mux/reg-mux.yaml + +required: + - compatible + - reg + - '#reset-cells' + +allOf: + - if: + properties: + compatible: + contains: + const: nxp,imx8ulp-avd-sim-reset + then: + required: + - mux-controller + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx8ulp-clock.h> + syscon@2da50000 { + compatible = "nxp,imx8ulp-avd-sim-reset", "syscon"; + reg = <0x2da50000 0x38>; + clocks = <&pcc5 IMX8ULP_CLK_AVD_SIM>; + #reset-cells = <1>; + + mux-controller { + compatible = "mmio-mux"; + #mux-control-cells = <1>; + mux-reg-masks = <0x8 0x00000200>; + }; + };