diff mbox series

[net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints

Message ID 20240523171750.2837331-1-robh@kernel.org
State Not Applicable
Headers show
Series [net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 31 lines checked
robh/patch-applied fail build log

Commit Message

Rob Herring (Arm) May 23, 2024, 5:17 p.m. UTC
The child nodes are missing "additionalProperties" constraints which
means any undocumented properties or child nodes are allowed. Add the
constraints and all the undocumented properties exposed by the fix.

Fixes: f562202fedad ("dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/net/pse-pd/ti,tps23881.yaml       | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Kory Maincent May 24, 2024, 7:39 a.m. UTC | #1
On Thu, 23 May 2024 12:17:50 -0500
"Rob Herring (Arm)" <robh@kernel.org> wrote:

> The child nodes are missing "additionalProperties" constraints which
> means any undocumented properties or child nodes are allowed. Add the
> constraints and all the undocumented properties exposed by the fix.

Acked-by: Kory Maincent <kory.maincent@bootlin.com>

Regards,
patchwork-bot+netdevbpf@kernel.org May 28, 2024, midnight UTC | #2
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 23 May 2024 12:17:50 -0500 you wrote:
> The child nodes are missing "additionalProperties" constraints which
> means any undocumented properties or child nodes are allowed. Add the
> constraints and all the undocumented properties exposed by the fix.
> 
> Fixes: f562202fedad ("dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints
    https://git.kernel.org/netdev/net/c/12f86b9af96a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml
index 4147adb11e10..6992d56832bf 100644
--- a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml
+++ b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml
@@ -29,13 +29,31 @@  properties:
       of the ports conversion matrix that establishes relationship between
       the logical ports and the physical channels.
     type: object
+    additionalProperties: false
+
+    properties:
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
 
     patternProperties:
       '^channel@[0-7]$':
         type: object
+        additionalProperties: false
+
+        properties:
+          reg:
+            maxItems: 1
+
         required:
           - reg
 
+    required:
+      - "#address-cells"
+      - "#size-cells"
+
 unevaluatedProperties: false
 
 required: