diff mbox series

dt-bindings: PCI: mediatek,mt7621-pcie: add PCIe host topology ascii graph

Message ID 20240522044321.3205160-1-sergio.paracuellos@gmail.com
State Not Applicable
Headers show
Series dt-bindings: PCI: mediatek,mt7621-pcie: add PCIe host topology ascii graph | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied fail build log

Commit Message

Sergio Paracuellos May 22, 2024, 4:43 a.m. UTC
MediaTek MT7621 PCIe subsys supports a single Root Complex (RC) with 3 Root
Ports. Add PCIe host topology ascii graph to the binding for completeness.

Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 .../bindings/pci/mediatek,mt7621-pcie.yaml    | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Krzysztof Kozlowski May 22, 2024, 6:48 a.m. UTC | #1
On 22/05/2024 06:43, Sergio Paracuellos wrote:
> MediaTek MT7621 PCIe subsys supports a single Root Complex (RC) with 3 Root
> Ports. Add PCIe host topology ascii graph to the binding for completeness.
> 
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  .../bindings/pci/mediatek,mt7621-pcie.yaml    | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
AngeloGioacchino Del Regno May 22, 2024, 7:17 a.m. UTC | #2
Il 22/05/24 06:43, Sergio Paracuellos ha scritto:
> MediaTek MT7621 PCIe subsys supports a single Root Complex (RC) with 3 Root
> Ports. Add PCIe host topology ascii graph to the binding for completeness.
> 
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Lovely.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   .../bindings/pci/mediatek,mt7621-pcie.yaml    | 29 +++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> index 6fba42156db6..c41608863d6c 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> @@ -13,6 +13,35 @@ description: |+
>     MediaTek MT7621 PCIe subsys supports a single Root Complex (RC)
>     with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
>   
> +                          MT7621 PCIe HOST Topology
> +
> +                                   .-------.
> +                                   |       |
> +                                   |  CPU  |
> +                                   |       |
> +                                   '-------'
> +                                       |
> +                                       |
> +                                       |
> +                                       v
> +                              .------------------.
> +                  .-----------|  HOST/PCI Bridge |------------.
> +                  |           '------------------'            | Type1
> +             BUS0 |                     |                     | Access
> +                  v                     v                     v On Bus0
> +          .-------------.        .-------------.       .-------------.
> +          | VIRTUAL P2P |        | VIRTUAL P2P |       | VIRTUAL P2P |
> +          |    BUS0     |        |    BUS0     |       |    BUS0     |
> +          |    DEV0     |        |    DEV1     |       |    DEV2     |
> +          '-------------'        '-------------'       '-------------'
> +    Type0        |          Type0       |         Type0       |
> +   Access   BUS1 |         Access   BUS2|        Access   BUS3|
> +   On Bus1       v         On Bus2      v        On Bus3      v
> +           .----------.           .----------.          .----------.
> +           | Device 0 |           | Device 0 |          | Device 0 |
> +           |  Func 0  |           |  Func 0  |          |  Func 0  |
> +           '----------'           '----------'          '----------'
> +
>   allOf:
>     - $ref: /schemas/pci/pci-host-bridge.yaml#
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
index 6fba42156db6..c41608863d6c 100644
--- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
@@ -13,6 +13,35 @@  description: |+
   MediaTek MT7621 PCIe subsys supports a single Root Complex (RC)
   with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
 
+                          MT7621 PCIe HOST Topology
+
+                                   .-------.
+                                   |       |
+                                   |  CPU  |
+                                   |       |
+                                   '-------'
+                                       |
+                                       |
+                                       |
+                                       v
+                              .------------------.
+                  .-----------|  HOST/PCI Bridge |------------.
+                  |           '------------------'            | Type1
+             BUS0 |                     |                     | Access
+                  v                     v                     v On Bus0
+          .-------------.        .-------------.       .-------------.
+          | VIRTUAL P2P |        | VIRTUAL P2P |       | VIRTUAL P2P |
+          |    BUS0     |        |    BUS0     |       |    BUS0     |
+          |    DEV0     |        |    DEV1     |       |    DEV2     |
+          '-------------'        '-------------'       '-------------'
+    Type0        |          Type0       |         Type0       |
+   Access   BUS1 |         Access   BUS2|        Access   BUS3|
+   On Bus1       v         On Bus2      v        On Bus3      v
+           .----------.           .----------.          .----------.
+           | Device 0 |           | Device 0 |          | Device 0 |
+           |  Func 0  |           |  Func 0  |          |  Func 0  |
+           '----------'           '----------'          '----------'
+
 allOf:
   - $ref: /schemas/pci/pci-host-bridge.yaml#