| Message ID | 20240520154711.7991-1-pratik.farkase@wsisweden.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2] dt-bindings: gpio: lsi,zevio-gpio: convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 3 warnings, 40 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 20 May 2024 17:47:08 +0200, Pratik Farkase wrote: > Convert Zevio GPIO Controller from text to dtschema. > > Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com> > --- > Changes in v2: > - Renamed file from `gpio-zevio.yaml` to `lsi,zevio-gpio.yaml` > - Fixed the space indentation in example > --- > --- > .../devicetree/bindings/gpio/gpio-zevio.txt | 16 -------- > .../bindings/gpio/lsi,zevio-gpio.yaml | 41 +++++++++++++++++++ > 2 files changed, 41 insertions(+), 16 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-zevio.txt > create mode 100644 Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/gpio/gpio-zevio.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240520154711.7991-1-pratik.farkase@wsisweden.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt deleted file mode 100644 index a37bd9ae2730..000000000000 --- a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt +++ /dev/null @@ -1,16 +0,0 @@ -Zevio GPIO controller - -Required properties: -- compatible: Should be "lsi,zevio-gpio" -- reg: Address and length of the register set for the device -- #gpio-cells: Should be two. The first cell is the pin number and the - second cell is used to specify optional parameters (currently unused). -- gpio-controller: Marks the device node as a GPIO controller. - -Example: - gpio: gpio@90000000 { - compatible = "lsi,zevio-gpio"; - reg = <0x90000000 0x1000>; - gpio-controller; - #gpio-cells = <2>; - }; diff --git a/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml b/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml new file mode 100644 index 000000000000..b5aae8124311 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-zevio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Zevio GPIO controller + +maintainers: + - Pratik Farkase <pratikfarkase94@gmail.com> + +properties: + compatible: + items: + - const: lsi,zevio-gpio + + reg: + maxItems: 1 + + "#gpio-cells": + const: 2 + + gpio-controller: true + +required: + - compatible + - reg + - "#gpio-cells" + - gpio-controller + +additionalProperties: false + +examples: + - | + gpio@90000000 { + compatible = "lsi,zevio-gpio"; + reg = <0x90000000 0x1000>; + gpio-controller; + #gpio-cells = <2>; + };
Convert Zevio GPIO Controller from text to dtschema. Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com> --- Changes in v2: - Renamed file from `gpio-zevio.yaml` to `lsi,zevio-gpio.yaml` - Fixed the space indentation in example --- --- .../devicetree/bindings/gpio/gpio-zevio.txt | 16 -------- .../bindings/gpio/lsi,zevio-gpio.yaml | 41 +++++++++++++++++++ 2 files changed, 41 insertions(+), 16 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-zevio.txt create mode 100644 Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml