| Message ID | 20240519-dt-bindings-mfd-syscon-split-v1-5-aaf996e2313a@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: mfd: syscon: Document more compatibles and require simpe-mfd description | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Sun, 19 May 2024 20:42:20 +0200, Krzysztof Kozlowski wrote: > ti,am654-serdes-ctrl is not a simple syscon device - it has children - > thus it should be fully documented in its own binding. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Context might depend on > https://lore.kernel.org/r/20240510123018.3902184-1-robh@kernel.org > and also further patches here depend on this one. > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 - > .../bindings/soc/ti/ti,am654-serdes-ctrl.yaml | 42 ++++++++++++++++++++++ > 2 files changed, 42 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index 91adf781e8ba..b17fa0487178 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -116,7 +116,6 @@ properties: - ti,am62-usb-phy-ctrl - ti,am62p-cpsw-mac-efuse - ti,am654-dss-oldi-io-ctrl - - ti,am654-serdes-ctrl - ti,j784s4-pcie-ctrl - ti,keystone-pllctrl diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-serdes-ctrl.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-serdes-ctrl.yaml new file mode 100644 index 000000000000..a10a3b89ae05 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-serdes-ctrl.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/ti/ti,am654-serdes-ctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments AM654 Serdes Control Syscon + +maintainers: + - Nishanth Menon <nm@ti.com> + +properties: + compatible: + items: + - const: ti,am654-serdes-ctrl + - const: syscon + + reg: + maxItems: 1 + + mux-controller: + $ref: /schemas/mux/reg-mux.yaml# + +required: + - compatible + - reg + - mux-controller + +additionalProperties: false + +examples: + - | + clock@4080 { + compatible = "ti,am654-serdes-ctrl", "syscon"; + reg = <0x4080 0x4>; + + mux-controller { + compatible = "mmio-mux"; + #mux-control-cells = <1>; + mux-reg-masks = <0x0 0x3>; /* lane select */ + }; + };
ti,am654-serdes-ctrl is not a simple syscon device - it has children - thus it should be fully documented in its own binding. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Context might depend on https://lore.kernel.org/r/20240510123018.3902184-1-robh@kernel.org and also further patches here depend on this one. --- Documentation/devicetree/bindings/mfd/syscon.yaml | 1 - .../bindings/soc/ti/ti,am654-serdes-ctrl.yaml | 42 ++++++++++++++++++++++ 2 files changed, 42 insertions(+), 1 deletion(-)